fix: Updated code and version requirements to work with Terraform 0.15

[TjeuKayim]

PR o'clock

Description

Replaced use of deprecated list() function with [] syntax and map() function with {} syntax.

Fix #1164

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[TjeuKayim]

Thanks for the review @barryib. I applied your suggestion and rebased on top of master.

[TjeuKayim]

I found that the deprecated function map() is also going to be removed in Terraform 0.15. I'm adding a simple patch for that one too.

[TjeuKayim]

The CI "Check Docs" failure is probably a false positive as I didn't alter anything related to the documentation in this pull request.

[RichiCoder1]

Terraform 0.15 is out and officially breaking things 😁

[barryib]

Terraform 0.15 is out and officially breaking things 😁

Will look into this during the week.

[bakayolo]

Hey guys,
When can we expect this one to be merged, we are currently being impacted by hashicorp/terraform#27172 that has been fixed in 0.15 but can't use 0.15 because of this current PR not merged.
Thanks!

[PavelSusloparov]

bad luck for people who use docker.mirror.hashicorp.services/hashicorp/terraform:light, terraform is updated to 0.15.0 there and terraform-aws-eks deps are failing.
Can we merge this in please?

[andyli]

It's a rather trivial change if you take a look at the file diff. Hope it wouldn't take too long to be merged.

[jtgorny]

Pls merge 😅
Call to function "list" failed: the "list" function was deprecated in Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to write a literal list.

[antonbabenko]

Terraform 0.15 is supported in version v15.0.0 that has been just released.

For the previous version of Terraform please use this module version ~> 14.0.

Let us know if there are any issues with this release.

@barryib I used the same release process as for all other modules we have and CHANGELOG changes were rather big ( eafc458 )

[vauchok]

Hi @antonbabenko,

I think you've missed list(var.worker_groups_launch_template[count.index]) in .terraform/modules/eks/workers_launch_template.tf line 167.

│ Error: Error in function call
│ 
│   on .terraform/modules/eks/workers_launch_template.tf line 167, in resource "aws_autoscaling_group" "workers_launch_template":
│  167:     for_each = (lookup(var.worker_groups_launch_template[count.index], "override_instance_types", null) != null) || (lookup(var.worker_groups_launch_template[count.index], "on_demand_allocation_strategy", local.workers_group_defaults["on_demand_allocation_strategy"]) != null) ? [] : list(var.worker_groups_launch_template[count.index])
│     ├────────────────
│     │ count.index is 1
│     │ var.worker_groups_launch_template is tuple with 4 elements
│ 
│ Call to function "list" failed: the "list" function was deprecated in
│ Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to
│ write a literal list.

[marcuz]

Hi @antonbabenko,

adding to @vauchok, also a map call is missing:

│ Error: Error in function call
│ 
│   on .terraform/modules/sud.eks_main/workers_launch_template.tf line 212, in resource "aws_autoscaling_group" "workers_launch_template":
│  212:         map(
│  213:           "key", tag_key,
│  214:           "value", tag_value,
│  215:           "propagate_at_launch", "true"
│  216:         )
│ 
│ Call to function "map" failed: the "map" function was deprecated in Terraform v0.12 and is no longer available; use tomap({ ... }) syntax to write a literal map.

[antonbabenko]

Weird that terraform validate command did not catch these errors. Fixed in #1307.

[antonbabenko]

Big thanks for the report!

v15.1.0 has been just released.

[marcuz]

@antonbabenko works now, thank you very much! 🙌

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.