Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: querying token factory from LCD #207

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

emidev98
Copy link
Contributor

@emidev98 emidev98 commented Nov 9, 2023

Enable querying token factory with URL encoded token denom, that way LCD can be queried without failing due the following error:

{
  "code": 12,
  "message": "Not Implemented",
  "details": []
}

This will not cause issues because denoms aren't allowed to have % which will no create any collisions

LCD Query;

image

CLI QUERY:

image

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #207 (1497f75) into release/v2.7 (8fb9783) will decrease coverage by 5.02%.
Report is 13 commits behind head on release/v2.7.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v2.7     #207      +/-   ##
================================================
- Coverage         70.43%   65.41%   -5.02%     
================================================
  Files                43       45       +2     
  Lines              2493     2137     -356     
================================================
- Hits               1756     1398     -358     
  Misses              583      583              
- Partials            154      156       +2     
Files Coverage Δ
x/tokenfactory/keeper/grpc_query.go 88.23% <100.00%> (+2.52%) ⬆️

... and 8 files with indirect coverage changes

@emidev98 emidev98 changed the title fix: querying token factory from outside fix: querying token factory from LCD Nov 10, 2023
@emidev98 emidev98 merged commit 23a8809 into release/v2.7 Nov 10, 2023
9 checks passed
@emidev98 emidev98 deleted the fix/v2.7/tokenfactory branch November 10, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants