-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow sending denoms with URL encoding #6847
Conversation
@emidev98 Thanks for the PR! Can you fix the lint please? 🙏 |
Hello @mattverse, for some reason the lint command does not work in my local. Could you run the linter please? Codewoners can push to the branch. Thanks! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
@emidev98 Happy to merge this once lint is fixed! |
Err we need to ensure we didn't introduce any serialization ambiguity here. We should be safe as long as:
I feel uncomfortable relying on that first assumption in such a load bearing way though. Could we instead just do a find replace of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah even better :) LGTM
Thanks @mattverse I have been very busy this days and didn't paid attention to some PRs. |
@ValarDragon Feel free to give secondary review for the change, planning to merge this by EOW! |
@emidev98 Definitely does save alot of people's lives :) Thanks so much for the PR 😃 |
Enable querying token factory with URL encoded token denom, that way LCD can be queried without failing due the following error:
This will not cause issues because denoms aren't allowed to have
%
which will no create any collisionsLCD Query;
CLI Query:
based on: terra-money/core#207