Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused sorted check #517

Merged
merged 1 commit into from
Jul 22, 2021
Merged

remove unused sorted check #517

merged 1 commit into from
Jul 22, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jul 22, 2021

Summary of changes

Apply final audit recommend.

  • Remove unused sorted check

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added enhancement New feature or request columbus-5 labels Jul 22, 2021
@yun-yeo yun-yeo requested a review from hanjukim July 22, 2021 00:43
@yun-yeo yun-yeo self-assigned this Jul 22, 2021
@yun-yeo yun-yeo merged commit da31cef into release/v0.5.x Jul 22, 2021
yun-yeo pushed a commit that referenced this pull request Aug 11, 2021
yun-yeo pushed a commit that referenced this pull request Aug 11, 2021
* upgrade to Cosmos SDK v0.39.2 (#430)

* upgrade to Cosmos SDK v0.39.2-rc1

* update to cosmos-sdk v0.39.2 RC2

* update to rc3

* update to v0.39.2

* [Bugfix] Register wasm query failed error to sdkerrors (#436)

* register wasm query failed error code
* fix description for querier

* fix treasury indicators querier

* [Feature] append blocking conditions for `/txs` query with `--public` flag on LCD (#437)

* block querying genesis txs from public node
* update txs query blocking condition for public node

* hotfix memory leak in go-cosmwasm iterator

* Implement tax caps querier for all whitelisted denoms (#442)

* add tax_caps querier
* add client interface & swagger update

Co-authored-by: Paul Kim <[email protected]>

* [Hotfix] treasury empty epoch data (#445)

* prevent division by zero, even though no epoch data is stored

* add test case for empty epoch data

* apply review for v0.4.2

* add empty epoch data load test case

* running startgate version

* update swagger-docs

* bugfix customized fee estimation interface

* change circleci to workflow

* housekeeping

* fix simulation

* fix simulation

* fix mempool logic to restrict gas limit for oracle txs

* Bump cosmwasm to v0.14.x (#465)

* Bump cosmwasm to v0.14.x

* fix lint

* Bump CosmWasm to v0.14.0-beta3

* update swagger-docs

* simulation update

* fix simulation

* fix test binary name

* fix test

* add MigrateMsg parsing & change test contract binary

* fix simulation

* fix msg validation

* fix test

* Update binding interface to reject IBC and Burn message

* implement wasm module migration script

* [Feature] Separate mint and burn swap pool (#467)

* sperate mint and burn swap pool

* fix lint

* add market migration script

* [Feature] v0.4 to v0.5 migration (#471)

* MsgAuth migration
* Market migration test
* Revert vesting rounding error
* Implement migrate cmd from v0.4 to v0.5
* Fix wrong bank import key to evidence

* [Feature] Bump cosmwasm to v0.14.0 (#472)

* update swagger-docs

* update proto comment & swagger-docs

* update proto doc generation script to generate docs with cosmos and ibc

* remove cosmos proto vesting account

* pass nano second for wasm BlockInfo

* allow empty admin on cli comment

* update swagger-docs

* fix instantiate&execute&migrate event ordering

* [Feature] Bump SDK version to v0.43.0-beta1 (#474)

* bump cosmos-sdk v0.43.0-beta1 & migrate msgauth to cosmos-sdk's authz module

* add address verifier

* revert gitflow

* fix address verifier condition

* remove not used TODO comments

* fix migration script

* fix test

* pass proto codec for wasm simulation

* bugfix to pass msgs to BroadcastTx at fee estimation

* bugfix cmd and estimate_fee

* remove log

* [Feature] Remove Treasury bespoke proposals (#475)

* remove treasury proposals

* update swagger docs

* [Feature] RewardWeight migration script update to burn all seigniorage (#477)

* update RewardWeight migration script to burn all seigniorage

* update swagger-docs

* revert core/BaseAccount codec to core/Account & swagger update

* add deprecation headers to custom rest handlers

* fix swagger

* Fix distribution legacy amino codec

* fix treasury migration

* update swagger docs

* legacy swagger update

* temporal fix for keyring dir not found error

* add deprecation flag to swagger

* convert pubkey replace to receive proto style pubkey object

* upgrade migration register for v0.5.0-beta3

* prepare docker files both for shared and static libary version

* make static.Dockerfile to default Dockerfile

* bugfix add treasury burn permission

* fix(terrad-env): Dockerfile VOLUME directive doesn't work on Azure (#489)

- VOLUME can be used as a string or JSON array
Cf https://docs.docker.com/engine/reference/builder/#volume

* [Feature] update organization name to terra-money (#486)

* org name update to terra-money

* remove circleci

* Update migration params for col5 (#491)

* update migration params for col5

* fix test

* increase wasm code size

* update migration code to add burn permission to treasury module (#493)

* [Bugfix] Return BASE/QUOTE exchange rate (#497)

* fix to return BASE/QUOTE exchange rate

* fix test

* return error when failed to parse msg

* change error comment

* [Feature] amino support to authz module with tax computing custom cli (#499)

* add amino support to authz module with tax computing custom cli

* fix to use custom transactino factory

* fill more denom meta infos

* update wasm cli to receive base64 bytes for raw query

* [Bugfix] limit wasm max gas with param (#502)

* limit wasm gas usage with param

* update comment

* use explicit subCtx

* fix swap grpc querier

* fix swap grpc querier wasm interface with cli

* register UpgradeHandler for v0.5.0

* [Feature] Apply audit (#504)

* move oracle SlashWindow check to outside of VotePeriod block

* fix to return BurnBasePool params

* allow to change oracle feeder to other address

* return error when oracle prevote request input is wrong

* remove unnecessary storage access at oracle tally

* sort price ballot at creation time to reduce duplicate sort cost

* fix testcase

* force to spend gas for failed address conversion

* fix to use ValidateFeeder to properly check bonding status of validator at oracle voting

* remove unnecessary oracle price ballot sort

* prevent empty treasury epoch state stored for cumulateive epochs

* prevent to create multiple vesting schedules for a denom

* remove CodeID from the MsgStoreCode

* fix simulation

* [Bump] cosmwasm to v0.15.0 (#509)

* bump cosmwasm to v0.15.0

* emit both from_contract and wasm events to support latest & legacy style, but block from_contract to be passed to a contract

* add deprecated comment to from_contract

* invalid replyOn check

* allow to overwrite response data with reply data

* charge gas for wasm events

* simplify gov msg parser

* use [email protected]

* update wasm event spec

* fix test for wasm gov

* update migration test code to use refect.DeepEqual()

* fix migration test to use json.Marshal for correct comparision

* register UpgradeHandler for v0.5.0

* fix bank encoding

* transfer all luna token to contract for proper simulation

* change require.Equal to assert.JSONEq

clear migration test

* fix treasury migration bug

* [Bump] sdk version to v0.43.0-rc0 (#507)

* bump sdk version to v0.43.0-rc0

* reuse app creator

* fix estimate_fee request interface unpacker

* remove unused files

* remove unused files

* fix to use new app config at testnet launch

* register all message amino codec to legacy.Cdc because authz module use this to get signbytes

* prevent register codec multiple times

* update cosmos proto for swagger update

* register feegrant amino codec to support legacy service

* change upgrade name to use -rc0

* change upgrade handler name to v0.5.0

* update swagger docs to include deprecated estimate_fee endpoints

* fix compute_tax endpoints

* Update README.md

* migrate market MintBasePool size to previous BasePool

* add amino support for StakeAuthorization (#512)

* update changelog

* keep consistency with wasmd

* feat(gov): add MsgVoteWeighted amino codec

* fix test

* remove unused sorted check (#517)

* rollback market base pool split (#518)

* remove unused sorted check

* rollback mint&burn pool split

* update swagger docs

* update readme

* [Feature] contract info query wasm interface (#520)

* add contract info query interface

* add testing code for contract info query wasm interface

* remove print

* Bump dependencies (#526)

* update changelog

* bump cosmwasm to v0.16.0-rc5 && cosmos-sdk to v0.43.0-rc2

* check reply error

* update test_contract for simulation

* bump cosmwasm to v0.16.0 & cosmos-sdk to v0.43.0-rc3

* add analysis for wasm contract for debugging purpose

* update ibc-go v1.0.0-rc4

* charge contract registering cost

* Update Dockerfile to use CosmWasm 0.16

* add changelog

Co-authored-by: Paul Kim <[email protected]>

* upgrade to Cosmos SDK v0.39.2 (#430)

* upgrade to Cosmos SDK v0.39.2-rc1

* update to cosmos-sdk v0.39.2 RC2

* update to rc3

* update to v0.39.2

* [Hotfix] treasury empty epoch data (#445)

* prevent division by zero, even though no epoch data is stored

* add test case for empty epoch data

* apply review for v0.4.2

* running startgate version

* update swagger-docs

* bugfix customized fee estimation interface

* change circleci to workflow

* housekeeping

* fix simulation

* fix simulation

* fix mempool logic to restrict gas limit for oracle txs

* Bump cosmwasm to v0.14.x (#465)

* Bump cosmwasm to v0.14.x

* fix lint

* Bump CosmWasm to v0.14.0-beta3

* update swagger-docs

* simulation update

* fix simulation

* fix test binary name

* fix test

* add MigrateMsg parsing & change test contract binary

* fix simulation

* fix msg validation

* fix test

* Update binding interface to reject IBC and Burn message

* implement wasm module migration script

* [Feature] Separate mint and burn swap pool (#467)

* sperate mint and burn swap pool

* fix lint

* add market migration script

* [Feature] v0.4 to v0.5 migration (#471)

* MsgAuth migration
* Market migration test
* Revert vesting rounding error
* Implement migrate cmd from v0.4 to v0.5
* Fix wrong bank import key to evidence

* [Feature] Bump cosmwasm to v0.14.0 (#472)

* update swagger-docs

* update proto comment & swagger-docs

* update proto doc generation script to generate docs with cosmos and ibc

* remove cosmos proto vesting account

* pass nano second for wasm BlockInfo

* allow empty admin on cli comment

* update swagger-docs

* fix instantiate&execute&migrate event ordering

* [Feature] Bump SDK version to v0.43.0-beta1 (#474)

* bump cosmos-sdk v0.43.0-beta1 & migrate msgauth to cosmos-sdk's authz module

* add address verifier

* revert gitflow

* fix address verifier condition

* remove not used TODO comments

* fix migration script

* fix test

* pass proto codec for wasm simulation

* bugfix to pass msgs to BroadcastTx at fee estimation

* bugfix cmd and estimate_fee

* remove log

* [Feature] Remove Treasury bespoke proposals (#475)

* remove treasury proposals

* update swagger docs

* [Feature] RewardWeight migration script update to burn all seigniorage (#477)

* update RewardWeight migration script to burn all seigniorage

* update swagger-docs

* revert core/BaseAccount codec to core/Account & swagger update

* add deprecation headers to custom rest handlers

* fix swagger

* Fix distribution legacy amino codec

* fix treasury migration

* update swagger docs

* legacy swagger update

* temporal fix for keyring dir not found error

* add deprecation flag to swagger

* convert pubkey replace to receive proto style pubkey object

* upgrade migration register for v0.5.0-beta3

* prepare docker files both for shared and static libary version

* make static.Dockerfile to default Dockerfile

* bugfix add treasury burn permission

* fix(terrad-env): Dockerfile VOLUME directive doesn't work on Azure (#489)

- VOLUME can be used as a string or JSON array
Cf https://docs.docker.com/engine/reference/builder/#volume

* [Feature] update organization name to terra-money (#486)

* org name update to terra-money

* remove circleci

* Update migration params for col5 (#491)

* update migration params for col5

* fix test

* increase wasm code size

* update migration code to add burn permission to treasury module (#493)

* [Bugfix] Return BASE/QUOTE exchange rate (#497)

* fix to return BASE/QUOTE exchange rate

* fix test

* return error when failed to parse msg

* change error comment

* [Feature] amino support to authz module with tax computing custom cli (#499)

* add amino support to authz module with tax computing custom cli

* fix to use custom transactino factory

* fill more denom meta infos

* update wasm cli to receive base64 bytes for raw query

* [Bugfix] limit wasm max gas with param (#502)

* limit wasm gas usage with param

* update comment

* use explicit subCtx

* fix swap grpc querier

* fix swap grpc querier wasm interface with cli

* register UpgradeHandler for v0.5.0

* [Feature] Apply audit (#504)

* move oracle SlashWindow check to outside of VotePeriod block

* fix to return BurnBasePool params

* allow to change oracle feeder to other address

* return error when oracle prevote request input is wrong

* remove unnecessary storage access at oracle tally

* sort price ballot at creation time to reduce duplicate sort cost

* fix testcase

* force to spend gas for failed address conversion

* fix to use ValidateFeeder to properly check bonding status of validator at oracle voting

* remove unnecessary oracle price ballot sort

* prevent empty treasury epoch state stored for cumulateive epochs

* prevent to create multiple vesting schedules for a denom

* remove CodeID from the MsgStoreCode

* fix simulation

* [Bump] cosmwasm to v0.15.0 (#509)

* bump cosmwasm to v0.15.0

* emit both from_contract and wasm events to support latest & legacy style, but block from_contract to be passed to a contract

* add deprecated comment to from_contract

* invalid replyOn check

* allow to overwrite response data with reply data

* charge gas for wasm events

* simplify gov msg parser

* use [email protected]

* update wasm event spec

* fix test for wasm gov

* update migration test code to use refect.DeepEqual()

* fix migration test to use json.Marshal for correct comparision

* register UpgradeHandler for v0.5.0

* fix bank encoding

* transfer all luna token to contract for proper simulation

* change require.Equal to assert.JSONEq

clear migration test

* fix treasury migration bug

* [Bump] sdk version to v0.43.0-rc0 (#507)

* bump sdk version to v0.43.0-rc0

* reuse app creator

* fix estimate_fee request interface unpacker

* remove unused files

* remove unused files

* fix to use new app config at testnet launch

* register all message amino codec to legacy.Cdc because authz module use this to get signbytes

* prevent register codec multiple times

* update cosmos proto for swagger update

* register feegrant amino codec to support legacy service

* change upgrade name to use -rc0

* change upgrade handler name to v0.5.0

* update swagger docs to include deprecated estimate_fee endpoints

* fix compute_tax endpoints

* migrate market MintBasePool size to previous BasePool

* Update README.md

* update changelog

* add amino support for StakeAuthorization (#512)

* keep consistency with wasmd

* fix test

* feat(gov): add MsgVoteWeighted amino codec

* remove unused sorted check (#517)

* rollback market base pool split (#518)

* remove unused sorted check

* rollback mint&burn pool split

* update swagger docs

* update readme

* [Feature] contract info query wasm interface (#520)

* add contract info query interface

* add testing code for contract info query wasm interface

* remove print

* Bump dependencies (#526)

* update changelog

* bump cosmwasm to v0.16.0-rc5 && cosmos-sdk to v0.43.0-rc2

* check reply error

* update test_contract for simulation

* bump cosmwasm to v0.16.0 & cosmos-sdk to v0.43.0-rc3

* add analysis for wasm contract for debugging purpose

* update ibc-go v1.0.0-rc4

* charge contract registering cost

* Update Dockerfile to use CosmWasm 0.16

* add changelog

Co-authored-by: Paul Kim <[email protected]>

* correct rebase

* check attributes length before doing attribute parse (#531)

* bump sdk version to 0.43 and ibc-go version to 1.0.0 (#529)

* bump sdk version to 0.43 and ibc-go version to 1.0.0

* add changelog

* update keyring for kwallet fix

* update changelog

* update migrate consensus params

* fix to use master branch for proto-check-breaking

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Paul Kim <[email protected]>
Co-authored-by: Zeid Marouf <[email protected]>
Co-authored-by: Do Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant