Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.5.x #468

Merged
merged 163 commits into from
Aug 11, 2021
Merged

Release/v0.5.x #468

merged 163 commits into from
Aug 11, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Apr 19, 2021

Summary of changes

Improvements

Bug Fixes

API Breaking Changes

Cosmos side breaking changes: here
Wallet Migration Guide: here
Contract Migration Guide: here

  • [GET] /auth/accounts/{address} does not return account coins
  • [POST] /txs/estimate_fee request and response format changed
Request (BaseReq + []sdk.Msg)
{
   "base_req":{
      "from":"terra1wg2mlrxdmnnkkykgqg4znky86nyrtc45q336yv",
      "memo":"Sent via Terra Station 🚀",
      "chain_id":"columbus-3",
      "account_number":"0",
      "sequence":"1",
      "gas":"200000",
      "gas_adjustment":"1.2",
      "fees":[
         {
            "denom":"uluna",
            "amount":"50"
         }
      ],
      "simulate":false
   },
   "msgs":[
      {
         "type":"bank/MsgSend",
         "value":{
            "from_address":"terra1wg2mlrxdmnnkkykgqg4znky86nyrtc45q336yv",
            "to_address":"terra14u47f8ufn2agqlpdpnfvcd2782zgnus9nslmfc",
            "amount":[
               {
                  "denom":"ukrw",
                  "amount":"10000000"
               }
            ]
         }
      }
   ]
}

Response (StdFee)
{
  "fee": {
    "gas": "string",
    "amount": [
      {
        "denom": "uluna",
        "amount": "50"
      }
    ]
  }
}
  • [GET] /market/terra_pool_delta removed, /market/mint_pool_delta & /market/burn_pool_delta added
  • [POST] /wasm/codes/{codeID}/migrate added for code migration
  • [POST] /wasm/codes/{codeID} request optionally specify admin field to make the contract as migratable
  • [GET] /wasm/contracts/{contractAddress} response format changed
    admin field replace migratable flag
{
  "code_id": "string",
  "address": "terra1wg2mlrxdmnnkkykgqg4znky86nyrtc45q336yv",
  "creator": "terra1wg2mlrxdmnnkkykgqg4znky86nyrtc45q336yv",
  "admin": "terra1wg2mlrxdmnnkkykgqg4znky86nyrtc45q336yv",
  "init_msg": "string"
}

Codec Changes

  • Added messages
    • wasm/MsgMigrateCode
    • wasm/MsgUpdateContractAdmin
    • wasm/MsgClearContractAdmin
    • feegrant/MsgGrantAllowance
    • feegrant/MsgRevokeAllowance
  • Removed messages
    • wasm/MsgUpdateContractOwner
  • Added Interfaces
    • feegrant/BasicAllowance
    • feegrant/PeriodicAllowance
    • feegrant/AllowedMsgAllowance
    • msgauth/StakeAuthorization

Param subspace changes

All terra module params now has camel case param subspace

  • Market
    • poolrecoveryperiod -> PoolRecoveryPeriod
    • minstabilityspread -> MinStabilitySpread
    • +MintBasePool
    • +BurnBasePool
  • Oracle
    • voteperiod -> VotePeriod
    • votethreshold -> VoteThreshold
    • rewardband -> RewardBand
    • rewarddistributionwindow -> RewardDistributionWindow
    • whitelist -> Whitelist
    • slashfraction -> SlashFraction
    • slashwindow -> SlashWindow
    • minvalidperwindow -> MinValidPerWindow
  • Treasury
    • taxpolicy -> TaxPolicy
    • rewardpolicy -> RewardPolicy
    • seigniorageburdentarget -> SeigniorageBurdenTarget
    • miningincrement -> MiningIncrement
    • windowshort -> WindowShort
    • windowlong -> WindowLong
    • windowprobation -> WindowProbation

Message Changes

  • MsgInstantiateContract
    • InitMsg format changed from base64 to json.RawMessage, so the developers need to pass object not base64 encoded string.
    • Migratable removed
    • Owner split into Sender and Admin. Admin is optional field to specify migratable flag and the executor of the migration.
  • MsgExecuteContract
    • ExecuteMsg format changed from base64 to json.RawMessage, so the developers need to pass object not base64 encoded string.
  • MsgMigrateContract
    • MigrateMsg format changed from base64 to json.RawMessage, so the developers need to pass object not base64 encoded string.
  • MsgGrantAuthorization => MsgGrant
    • Authorization and Period merged into Grant.
    • Period renamed to Expiration and format changed from time.Duration to time.Time.
  • MsgRevokeAuthorization => MsgRevoke
    • AuthorizationMsgType renamed to MsgTypeUrl
  • MsgExecAuthorization => MsgExec
  • GenericAuthorization
    • GrantMsgType renamed Msg and it represents proto type url
  • MsgVoteWeighted
    • new governance message to submit weighted vote

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

alessio and others added 21 commits December 1, 2020 14:26
* upgrade to Cosmos SDK v0.39.2-rc1

* update to cosmos-sdk v0.39.2 RC2

* update to rc3

* update to v0.39.2
* register wasm query failed error code
* fix description for querier
… flag on LCD (#437)

* block querying genesis txs from public node
* update txs query blocking condition for public node
* add tax_caps querier
* add client interface & swagger update

Co-authored-by: Paul Kim <[email protected]>
* prevent division by zero, even though no epoch data is stored

* add test case for empty epoch data
* Bump cosmwasm to v0.14.x

* fix lint

* Bump CosmWasm to v0.14.0-beta3

* update swagger-docs

* simulation update

* fix simulation

* fix test binary name

* fix test

* add MigrateMsg parsing & change test contract binary

* fix simulation

* fix msg validation

* fix test

* Update binding interface to reject IBC and Burn message

* implement wasm module migration script
* sperate mint and burn swap pool

* fix lint

* add market migration script
* MsgAuth migration
* Market migration test
* Revert vesting rounding error
* Implement migrate cmd from v0.4 to v0.5
* Fix wrong bank import key to evidence
@yun-yeo yun-yeo self-assigned this May 6, 2021
yun-yeo and others added 19 commits August 11, 2021 10:27
* remove unused sorted check

* rollback mint&burn pool split

* update swagger docs

* update readme
* add contract info query interface

* add testing code for contract info query wasm interface

* remove print
* update changelog

* bump cosmwasm to v0.16.0-rc5 && cosmos-sdk to v0.43.0-rc2

* check reply error

* update test_contract for simulation

* bump cosmwasm to v0.16.0 & cosmos-sdk to v0.43.0-rc3

* add analysis for wasm contract for debugging purpose

* update ibc-go v1.0.0-rc4

* charge contract registering cost

* Update Dockerfile to use CosmWasm 0.16

* add changelog

Co-authored-by: Paul Kim <[email protected]>
* bump sdk version to 0.43 and ibc-go version to 1.0.0

* add changelog

* update keyring for kwallet fix
@yun-yeo yun-yeo marked this pull request as ready for review August 11, 2021 05:45
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #468 (ff7e121) into master (8dd3b35) will decrease coverage by 21.34%.
The diff coverage is 25.72%.

❗ Current head ff7e121 differs from pull request most recent head 57ff045. Consider uploading reports for the commit 57ff045 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #468       +/-   ##
===========================================
- Coverage   66.19%   44.85%   -21.35%     
===========================================
  Files         116      118        +2     
  Lines        5887     6822      +935     
===========================================
- Hits         3897     3060      -837     
- Misses       1771     3526     +1755     
- Partials      219      236       +17     
Impacted Files Coverage Δ
app/encoding.go 0.00% <0.00%> (ø)
app/export.go 0.00% <0.00%> (-28.83%) ⬇️
app/genesis.go 0.00% <0.00%> (ø)
app/app.go 0.67% <0.75%> (-86.77%) ⬇️
custom/staking/wasm/interface.go 16.35% <16.35%> (ø)
custom/bank/wasm/interface.go 31.25% <31.25%> (ø)
custom/auth/ante/ante.go 58.62% <58.62%> (ø)
custom/authz/legacy/v043/migrate.go 68.96% <68.96%> (ø)
custom/auth/ante/spamming_prevention.go 70.83% <70.83%> (ø)
custom/distribution/wasm/interface.go 72.72% <72.72%> (ø)
... and 217 more

@yun-yeo yun-yeo requested a review from hanjukim August 11, 2021 05:51
@yun-yeo yun-yeo added the enhancement New feature or request label Aug 11, 2021
@yun-yeo yun-yeo merged commit d6037b9 into master Aug 11, 2021
@yun-yeo yun-yeo deleted the release/v0.5.x branch October 6, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants