Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed job id in test report path for tt-github-actions #1434

Closed
wants to merge 1 commit into from

Conversation

nsmithtt
Copy link
Contributor

No description provided.

@nsmithtt
Copy link
Contributor Author

@vmilosevic the job id method fails with:

/__w/_temp/1c5acf9c-4819-41c1-89c6-0c6ad5c57343.sh: line 9: curl: command not found
/__w/_temp/1c5acf9c-4819-41c1-89c6-0c6ad5c57343.sh: line 9: jq: command not found
  1. It's insane to me that GH doesn't already have an env/string with this information, seriously wtf
  2. I'm not sure what the best solution is, I could hack an apt install, but this seems wasteful, I guess we should install curl and jq in our containers?

@vmilosevic
Copy link
Contributor

vmilosevic commented Nov 29, 2024

It's insane to me that GH doesn't already have an env/string with this information, seriously wtf

Yes, and no other way to link attachments to jobs that produced them :(

I'm not sure what the best solution is, I could hack an apt install, but this seems wasteful, I guess we should install curl and jq in our containers?

I'll sort this out in #1420

@nsmithtt
Copy link
Contributor Author

nsmithtt commented Dec 4, 2024

This was handled as part of #1420, closing.

@nsmithtt nsmithtt closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants