-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10034: Binary shift operators #16055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdjogoTT
reviewed
Dec 16, 2024
rdjogoTT
reviewed
Dec 16, 2024
Should this tie into the binary_NG op type from Yan? https://github.com/tenstorrent/tt-metal/pull/16068/files |
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
2 times, most recently
from
December 17, 2024 02:46
dcf4b3a
to
a02a6af
Compare
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
from
December 17, 2024 02:54
a02a6af
to
b974c3d
Compare
Yes @cmaryanTT, it will compute on sfpu |
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
from
December 17, 2024 12:05
b974c3d
to
7dd83ac
Compare
KalaivaniMCW
requested review from
patrickroberts,
yan-zaretskiy and
eyonland
as code owners
December 17, 2024 13:06
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
from
December 17, 2024 13:19
7dd83ac
to
13b0412
Compare
umadevimcw
approved these changes
Dec 17, 2024
VirdhatchaniKN
approved these changes
Dec 17, 2024
rdjogoTT
approved these changes
Dec 17, 2024
mcw-anasuya
approved these changes
Dec 17, 2024
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
from
December 17, 2024 19:04
13b0412
to
8554023
Compare
mouliraj-mcw
approved these changes
Dec 18, 2024
eyonland
approved these changes
Dec 18, 2024
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
3 times, most recently
from
December 18, 2024 16:42
fa75196
to
7c7271f
Compare
KalaivaniMCW
force-pushed
the
kalaivani/binary_shift
branch
from
December 18, 2024 16:53
7c7271f
to
06f493b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue #10034
Problem description
Binary left/right shift operators
What's changed
add ttnn support for sfpu binary bitwise shift operators
Checklist
https://github.com/tenstorrent/tt-metal/actions/runs/12394449160