Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary Shift operators #10034

Closed
Tracked by #9702
, #13795 ,  #14073
...
VirdhatchaniKN opened this issue Jul 9, 2024 · 6 comments
Closed
Tracked by #9702
, #13795 ,  #14073
...

Binary Shift operators #10034

VirdhatchaniKN opened this issue Jul 9, 2024 · 6 comments
Assignees
@eyonland
Labels
op_cat: eltwise Op Generalization Generalization and relaxations of requirements in Ops P1

Comments

@VirdhatchaniKN
Copy link
Contributor

VirdhatchaniKN commented Jul 9, 2024 •
edited
Loading

Master issue : #9702

Op Requirement :

  • ElemwiseBinary/ELEMWISE_BINARY_LEFT_SHIFT
  • ElemwiseBinary/ELEMWISE_BINARY_RIGHT_SHIFT

Issues :

Initial Implementation done in #8636
This implementation requires the involvement of a lot of ops, which may lead to performance issues.
@VirdhatchaniKN VirdhatchaniKN mentioned this issue Jul 9, 2024
Open
11 tasks
@KalaivaniMCW
Copy link
Contributor

Hi @rtawfik01 @rdjogoTT

Is it possible to support shift operation for two tensors (like it is available in bitwise operation)?
At present, the second operand for shift operation takes only a single integer parameter
Image

Bitwise ops:
Image

@eyonland eyonland mentioned this issue Oct 15, 2024
Open
@rtawfik01 rtawfik01 mentioned this issue Oct 21, 2024
Closed
@eyonland eyonland mentioned this issue Oct 21, 2024
Closed
4 tasks
@umadevimcw umadevimcw added the Op Generalization Generalization and relaxations of requirements in Ops label Oct 29, 2024
@rdjogoTT rdjogoTT mentioned this issue Dec 5, 2024
Closed
@rdjogoTT rdjogoTT assigned rdjogoTT and unassigned ttmtrajkovic Dec 10, 2024
rdjogoTT added a commit that referenced this issue Dec 10, 2024
@rdjogoTT
#10034: Add binary shift LLK WHB0
349e36f
rdjogoTT added a commit that referenced this issue Dec 10, 2024
@rdjogoTT
#10034: Add binary shift LLK WHB0
c1e9357
rdjogoTT added a commit that referenced this issue Dec 11, 2024
@rdjogoTT
#10034: Add binary shift LLK WHB0
455592a
rdjogoTT added a commit that referenced this issue Dec 11, 2024
@rdjogoTT
#10034: Add binary shift LLK BH
c71aabc
@rdjogoTT rdjogoTT mentioned this issue Dec 11, 2024
Merged
3 tasks
rdjogoTT added a commit that referenced this issue Dec 12, 2024
@rdjogoTT
#10034: Add binary shift LLK WHB0
aa9bb77
rdjogoTT added a commit that referenced this issue Dec 12, 2024
@rdjogoTT
#10034: Add binary shift LLK BH
da055e8
rdjogoTT added a commit that referenced this issue Dec 12, 2024
@rdjogoTT
#10034: Add binary shift LLK WHB0
33debd5
rdjogoTT added a commit that referenced this issue Dec 12, 2024
@rdjogoTT
#10034: Add binary shift LLK BH
6444d7c
rdjogoTT added a commit that referenced this issue Dec 12, 2024
@rdjogoTT
#10034: Update LLK submodules
bf11788
rdjogoTT added a commit that referenced this issue Dec 12, 2024
@rdjogoTT
Add LLK and API for binary shift left/right (#15926)
6e983a7 
### Ticket
[Link to Github
Issue](#10034)

### What's changed
Implemented binary left/right shift as binary SFPU OPs.

### Checklist
- [x] Post commit CI passes:
https://github.com/tenstorrent/tt-metal/actions/runs/12287866881
- [x] Blackhole Post commit:
https://github.com/tenstorrent/tt-metal/actions/runs/12287867702
- [x] New/Existing tests provide coverage for changes - will be added in
future PR
@rdjogoTT
Copy link
Contributor

LLK added here: #15926

@rdjogoTT rdjogoTT removed their assignment Dec 13, 2024
@rdjogoTT rdjogoTT removed the LLK label Dec 13, 2024
@cmaryanTT
Copy link

@eyonland - please assign someone for implementation of this. The LLK should be present, per Radomir's comment. This should be high priority because it could be used to address some customer requests.

KalaivaniMCW added a commit that referenced this issue Dec 16, 2024
@KalaivaniMCW
#10034: Binary shift operators
d1e39e2
@KalaivaniMCW KalaivaniMCW mentioned this issue Dec 16, 2024
Merged
6 tasks
KalaivaniMCW added a commit that referenced this issue Dec 17, 2024
@KalaivaniMCW
#10034: Binary shift operators
dcf4b3a
KalaivaniMCW added a commit that referenced this issue Dec 17, 2024
@KalaivaniMCW
#10034: Binary shift operators
a02a6af
KalaivaniMCW added a commit that referenced this issue Dec 17, 2024
@KalaivaniMCW
#10034: Binary shift operators
b974c3d
KalaivaniMCW added a commit that referenced this issue Dec 17, 2024
@KalaivaniMCW
#10034: Binary shift operators
7dd83ac
KalaivaniMCW added a commit that referenced this issue Dec 17, 2024
@KalaivaniMCW @Aswinmcw
#10034: Binary shift operators
13b0412
@eyonland
Copy link
Contributor

Pending merge of
#16055

KalaivaniMCW added a commit that referenced this issue Dec 17, 2024
@KalaivaniMCW
#10034: Binary shift operators
8554023
KalaivaniMCW added a commit that referenced this issue Dec 18, 2024
@KalaivaniMCW
#10034: Binary shift operators
bd52248
KalaivaniMCW added a commit that referenced this issue Dec 18, 2024
@KalaivaniMCW
#10034: Binary shift operators
fa75196
KalaivaniMCW added a commit that referenced this issue Dec 18, 2024
@KalaivaniMCW
#10034: Binary shift operators
7c7271f
KalaivaniMCW added a commit that referenced this issue Dec 18, 2024
@KalaivaniMCW
#10034: Binary shift operators
06f493b
KalaivaniMCW added a commit that referenced this issue Dec 18, 2024
@KalaivaniMCW
#10034: Binary shift operators (#16055)
808b43b 
### Ticket
Link to Github Issue #10034 

### Problem description
Binary left/right shift operators

### What's changed
add ttnn support for sfpu binary bitwise shift operators

### Checklist
- [x] Post commit CI passes
https://github.com/tenstorrent/tt-metal/actions/runs/12372840148
https://github.com/tenstorrent/tt-metal/actions/runs/12394449160
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [x] New/Existing tests provide coverage for changes
@eyonland
Copy link
Contributor

@VirdhatchaniKN , would you confirm that this can be closed now?

@VirdhatchaniKN
Copy link
Contributor Author

Closing ticket as PR #16055 has been merged to main

@prajaramanTT prajaramanTT mentioned this issue Dec 19, 2024
Open
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyonland eyonland

Labels
op_cat: eltwise Op Generalization Generalization and relaxations of requirements in Ops P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@umadevimcw @eyonland @VirdhatchaniKN @ttmtrajkovic @KalaivaniMCW @rdjogoTT @mouliraj-mcw @mcw-anasuya @cmaryanTT