Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTNN log-alike ops incomplete documentation #8142

Closed
Tracked by #13795
npetrovic-tenstorrent opened this issue May 4, 2024 · 3 comments
Closed
Tracked by #13795

TTNN log-alike ops incomplete documentation #8142

npetrovic-tenstorrent opened this issue May 4, 2024 · 3 comments
Assignees
@mouliraj-mcw
Labels
bug Something isn't working op_cat: eltwise

Comments

@npetrovic-tenstorrent
Copy link
Contributor

npetrovic-tenstorrent commented May 4, 2024 •
edited
Loading

For the following TTNN tensor log-alike ops:

  • log2, log10, log1p, log_sigmoid

The documentation does not cover supported data types (BFLOAT16/BFLOAT8_B) neither the supported layouts (ROW_MAJOR/TILE).

However, it seems that these ops actually support BFLOAT16 with TILE layout. ROW_MAJOR is not supported.
However, some of them do execute with BFLOAT8_B (low PCC on GS in some cases):

  • log2, log_sigmoid, log10

Log_sigmoid seems to pass with BFLOAT8_B on both GS and WH.
Log1p - seems that a BFLOAT8_B not supported.
@npetrovic-tenstorrent npetrovic-tenstorrent added bug Something isn't working op_cat: eltwise labels May 4, 2024
@VirdhatchaniKN VirdhatchaniKN self-assigned this May 9, 2024
@VirdhatchaniKN
Copy link
Contributor

Fix for log_sigmoid provided in PR #8050
Fix for log2, log10, log1p provided in PR #7827

@VirdhatchaniKN VirdhatchaniKN mentioned this issue May 10, 2024
Closed
@VirdhatchaniKN
Copy link
Contributor

Will revisit after Migration task - #7711 (comment)

@eyonland eyonland assigned mcw-anasuya and unassigned bharane-ab Sep 30, 2024
bharane-ab added a commit that referenced this issue Oct 1, 2024
@bharane-ab
#8142: update pybind doc for log like ops
3c3f250
@bharane-ab bharane-ab mentioned this issue Oct 1, 2024
Draft
1 task
bharane-ab added a commit that referenced this issue Oct 1, 2024
@bharane-ab
#8142: update pybind doc for log like ops
85347de
@eyonland eyonland mentioned this issue Oct 15, 2024
Open
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Add documentationfor log alike ops
d3f481e
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Update sweep tests
08a9714
@mouliraj-mcw mouliraj-mcw mentioned this issue Oct 18, 2024
Merged
1 task
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Add documentation for log alike ops
8af6470
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Update sweep tests
c05a416
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Update sweep tests
58f160b
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Update sweep tests
73c4723
mouliraj-mcw added a commit that referenced this issue Oct 18, 2024
@mouliraj-mcw
#8142: Update sweep tests
0590119
mouliraj-mcw added a commit that referenced this issue Oct 22, 2024
@mouliraj-mcw
#8142: Add documentation for log alike ops
544b512
mouliraj-mcw added a commit that referenced this issue Oct 22, 2024
@mouliraj-mcw
#8142: Update sweep tests
f043670
mouliraj-mcw added a commit that referenced this issue Oct 23, 2024
@mouliraj-mcw
#8142: Add documentation for log alike ops
49ff8cb
mouliraj-mcw added a commit that referenced this issue Oct 23, 2024
@mouliraj-mcw
#8142: Update sweep tests
10cf850
mouliraj-mcw added a commit that referenced this issue Oct 24, 2024
@mouliraj-mcw
#8142: Add documentation for log alike ops
3bc5dc9
mouliraj-mcw added a commit that referenced this issue Oct 24, 2024
@mouliraj-mcw
#8142: Update sweep tests
4d97e49
mouliraj-mcw added a commit that referenced this issue Oct 24, 2024
@mouliraj-mcw
#8142: Add documentation for log alike ops
2ecbd20
mouliraj-mcw added a commit that referenced this issue Oct 24, 2024
@mouliraj-mcw
#8142: Update sweep tests
ac50638
mouliraj-mcw added a commit that referenced this issue Oct 24, 2024
@mouliraj-mcw
#8142: TTNN log-alike ops incomplete documentation (#13969)
af3d010 
* #8142: Add documentation for log alike ops

* #8142: Update sweep tests
@mcw-anasuya
Copy link
Contributor

Doc updated and merged to main, hence closing this issue.

ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this issue Nov 12, 2024
@mouliraj-mcw
tenstorrent#8142: TTNN log-alike ops incomplete documentation (tensto…
76dd5d1 
…rrent#13969)

* tenstorrent#8142: Add documentation for log alike ops

* tenstorrent#8142: Update sweep tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mouliraj-mcw mouliraj-mcw

Labels
bug Something isn't working op_cat: eltwise
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@umadevimcw @npetrovic-tenstorrent @bharane-ab @VirdhatchaniKN @mouliraj-mcw @mcw-anasuya