Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update required version of html5lib to 1.0b10 (#589)" #604

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

jart
Copy link
Contributor

@jart jart commented Oct 3, 2017

This reverts commit 46c153f and unfixes #588. A regression was caused where the following happens:

(tf)html5lib-rollback jart@compy:~/code/tensorboard$ tensorboard --logdir=~/tb/fast
Traceback (most recent call last):
  File "/usr/local/google/home/jart/tf/bin/tensorboard", line 7, in <module>
    from tensorboard.main import main
  File "/usr/local/google/home/jart/tf/local/lib/python2.7/site-packages/tensorboard/main.py", line 36, in <module>
    from tensorboard.plugins.audio import audio_plugin
  File "/usr/local/google/home/jart/tf/local/lib/python2.7/site-packages/tensorboard/plugins/audio/audio_plugin.py", line 27, in <module>
    from tensorboard import plugin_util
  File "/usr/local/google/home/jart/tf/local/lib/python2.7/site-packages/tensorboard/plugin_util.py", line 21, in <module>
    import bleach
  File "/usr/local/google/home/jart/tf/local/lib/python2.7/site-packages/bleach/__init__.py", line 14, in <module>
    from html5lib.sanitizer import HTMLSanitizer
ImportError: No module named sanitizer

Since html5lib 0.999999999 totally breaks the API of 0.9999999, we would probably need to upgrade to bleach 2.0 (see #427) in order to use the latest html5lib. Please note that upgrading past the breakage would require upgrading everyone at Google.

Copy link
Member

@chihuahua chihuahua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks!

@jart jart merged commit 7b031b0 into tensorflow:master Oct 4, 2017
@jart jart deleted the html5lib-rollback branch October 4, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants