Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks for TensorBoard 0.1.8 #593

Merged
merged 3 commits into from
Oct 3, 2017
Merged

Conversation

jart
Copy link
Contributor

@jart jart commented Sep 30, 2017

This is a patch release to polish the pip package. It's now smaller and has better metadata.

cc: @jakirkham from #556
cc: @alanpurple from #588

@jart jart requested a review from chihuahua September 30, 2017 00:37
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jart jart force-pushed the cherry-picks branch 2 times, most recently from 9bb783c to d77efc1 Compare October 2, 2017 23:58
- Include LICENSE in metadata (Fixes tensorflow#556)
- Add mini README file in Restructured Text
- Stop copying deps (e.g. six) into our whl file

The LICENSE file was copied into this directory in the interest of avoiding
adding a BUILD file to the top level directory.
These errors aren't very helpful and they tend to fill up logs. They could be
caused by something as innocent as `curl -N http://localhost:6006/ | head`. It
could also be caused by firewalls, or perhaps the browser abruptly navigating
somewhere else. So we wouldn't want users to mistake these as meaningful when
troubleshooting.
@jart
Copy link
Contributor Author

jart commented Oct 3, 2017

I removed the cherry pick that upgrades html5lib (which is now being reverted from master in #604) because it broke bleach on import.

@jart jart merged commit 4245a6f into tensorflow:0.1 Oct 3, 2017
@jart jart deleted the cherry-picks branch October 3, 2017 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants