Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change terser configuration to workaround threejs/terser incompatibility. #5495

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Change terser configuration to workaround threejs/terser incompatibility. #5495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tensorboard/defs/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ def tf_js_binary(
terser_minified(
name = internal_result_name,
src = internal_rollup_name,
# Notes about the terser config:
# compress.passes - this is set to '1' to workaround issue with
# terser and threejs. In practice it (surprisingly) generates
# smaller results than when it was previously set to '3'.
config_file = "//tensorboard/defs:terser_config.json",
visibility = ["//visibility:private"],
sourcemap = False,
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/defs/terser_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
},
"compress": {
"keep_fnames": true,
"passes": 3,
"passes": 1,
"pure_getters": true,
"reduce_funcs": true,
"reduce_vars": true,
Expand Down