Change terser configuration to workaround threejs/terser incompatibility. #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incompatibility. It fixes a problem with loading tensorboard in Safari.
JamesHollyer
approved these changes
Jan 13, 2022
bmd3k
added a commit
to bmd3k/tensorboard
that referenced
this pull request
Jan 19, 2022
…mpatibility (tensorflow#5495) Users have reported problems loading TensorBoard in Safari: tensorflow#5489 Thanks to @severo and @bileschi we were able to identify the problem to an incompatibility between threejs (which we use for WebGL rendering) and terser (which we use for minimizing/optimizing our code). Angular encountered this problem last year and worked around it by changing their terser config by reducing number of passes from 3 to 2: * angular/angular-cli#21107 * angular/angular-cli@2c2b499 In our case I have to reduce the number of terser passes from 3 to 1. For some reason reducing to 2 does not solve the problem. This change surprisingly appears to reduce binary size. Before this change the size of index.js is 7672844 bytes. After this change the size of index.js is 7670992 bytes -- reducing binary size by 1852 bytes.
bmd3k
added a commit
that referenced
this pull request
Jan 20, 2022
…mpatibility (#5495) Users have reported problems loading TensorBoard in Safari: #5489 Thanks to @severo and @bileschi we were able to identify the problem to an incompatibility between threejs (which we use for WebGL rendering) and terser (which we use for minimizing/optimizing our code). Angular encountered this problem last year and worked around it by changing their terser config by reducing number of passes from 3 to 2: * angular/angular-cli#21107 * angular/angular-cli@2c2b499 In our case I have to reduce the number of terser passes from 3 to 1. For some reason reducing to 2 does not solve the problem. This change surprisingly appears to reduce binary size. Before this change the size of index.js is 7672844 bytes. After this change the size of index.js is 7670992 bytes -- reducing binary size by 1852 bytes.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…mpatibility (tensorflow#5495) Users have reported problems loading TensorBoard in Safari: tensorflow#5489 Thanks to @severo and @bileschi we were able to identify the problem to an incompatibility between threejs (which we use for WebGL rendering) and terser (which we use for minimizing/optimizing our code). Angular encountered this problem last year and worked around it by changing their terser config by reducing number of passes from 3 to 2: * angular/angular-cli#21107 * angular/angular-cli@2c2b499 In our case I have to reduce the number of terser passes from 3 to 1. For some reason reducing to 2 does not solve the problem. This change surprisingly appears to reduce binary size. Before this change the size of index.js is 7672844 bytes. After this change the size of index.js is 7670992 bytes -- reducing binary size by 1852 bytes.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…mpatibility (tensorflow#5495) Users have reported problems loading TensorBoard in Safari: tensorflow#5489 Thanks to @severo and @bileschi we were able to identify the problem to an incompatibility between threejs (which we use for WebGL rendering) and terser (which we use for minimizing/optimizing our code). Angular encountered this problem last year and worked around it by changing their terser config by reducing number of passes from 3 to 2: * angular/angular-cli#21107 * angular/angular-cli@2c2b499 In our case I have to reduce the number of terser passes from 3 to 1. For some reason reducing to 2 does not solve the problem. This change surprisingly appears to reduce binary size. Before this change the size of index.js is 7672844 bytes. After this change the size of index.js is 7670992 bytes -- reducing binary size by 1852 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported problems loading TensorBoard in Safari: #5489
Thanks to @severo and @bileschi we were able to identify the problem to an incompatibility between threejs (which we use for WebGL rendering) and terser (which we use for minimizing/optimizing our code).
Angular encountered this problem last year and worked around it by changing their terser config by reducing number of passes from 3 to 2:
In our case I have to reduce the number of terser passes from 3 to 1. For some reason reducing to 2 does not solve the problem.
This change surprisingly appears to reduce binary size. Before this change the size of index.js is 7672844 bytes. After this change the size of index.js is 7670992 bytes -- reducing binary size by 1852 bytes.