Fix the build for bazel 0.16. #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel 0.16 comes with java 1.9, which doesn't have javax/annotation/Generated, which dagger 2.9 needed. rules_closure 0.8.0 updates its dagger deps to 2.14.1, which resolves the issue.
jart
approved these changes
Aug 7, 2018
wchargin
added a commit
that referenced
this pull request
Nov 29, 2018
Summary: Some modules have `@demo` annotations that point to nonexistent demos, so we fix or remove those references as appropriate. The `google-chart` demo is not working and does not appear to have ever worked: when running it on its initial commit after cherry-picking #1334 we see only a blank page. However, deleting this demo isn’t trivial, because the main profile dashboard depends on it for some reason. As this plugin is still being actively developed, we’ll leave the demo alone for now: it’s not actually causing any problems. Context: <#1645 (comment)> Test Plan: Note that `git grep @demo` only lists correct paths to working demos. wchargin-branch: remove-broken-demos
wchargin
added a commit
that referenced
this pull request
Nov 29, 2018
Summary: Some modules have `@demo` annotations that point to nonexistent demos, so we fix or remove those references as appropriate. The `google-chart` demo is not working and does not appear to have ever worked: when running it on its initial commit after cherry-picking #1334 we see only a blank page. However, deleting this demo isn’t trivial, because the main profile dashboard depends on it for some reason. As this plugin is still being actively developed, we’ll leave the demo alone for now: it’s not actually causing any problems. Context: <#1645 (comment)> Test Plan: Note that `git grep @demo` only lists correct paths to working demos. wchargin-branch: remove-broken-demos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 0.16 comes with java 1.9, which doesn't have javax/annotation/Generated,
which dagger 2.9 needed.
rules_closure 0.8.0 updates its dagger deps to 2.14.1, which resolves
the issue.