docs: add instructions for building old revisions #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
When bisecting or exploring the history, it can be useful to build old
commits. Unfortunately, due to backward-incompatible changes in Bazel,
this is not possible natively. This commit describes a workaround.
It’s unfortunately not too discoverable in `DEVELOPMENT.md`, but at
least it’s somewhere.
Test Plan:
$ git checkout -q "$(git rev-list origin/master --before=2018-08-01 -n 1)"
$ bazel build //tensorboard 2>&1 | tail -n 1
FAILED: Build did NOT complete successfully
$ git cherry-pick bc4e7a6 >/dev/null
$ bazel build //tensorboard 2>&1 | tail -n 1
INFO: Build completed successfully, 117 total actions
wchargin-branch: docs-build-old
|
I agree. Please note the Bazel team has many more pointless breaking changes in the works: https://docs.bazel.build/versions/master/skylark/backward-compatibility.html |
nfelt
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When bisecting or exploring the history, it can be useful to build old
commits. Unfortunately, due to backward-incompatible changes in Bazel,
this is not possible natively. This commit describes a workaround.
It’s unfortunately not too discoverable in
DEVELOPMENT.md, but atleast it’s somewhere.
Test Plan:
wchargin-branch: docs-build-old