-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TensorFlow community-builds table #24
Conversation
|
Thanks, @angerson ! |
@angerson will take a look next week. the CI cluster needs a reboot. |
Yeah, good idea. Once this PR is ready to go I'll prep the docs changes and do them at the same time. |
@angerson links to Linaro builds are pointing into proper places. Also contact persons match. We are at 1.5.15 / 2.4.1 / git HEAD (2.6.0). |
Hi Austin,
>The PPC Nightly builds are disabled and didn't pass often. Should we remove them?
>The PPC v2 build hasn't run since TF 2.2, should it be removed?
For the ppc builds, we had a problem in Eigen where an optimization was added for ppc64le, but it broke the integration with Tensorflow, so the daily was disabled in the Jenkins. I don't want to remove them.
The issue was recently resolved: tensorflow/tensorflow#44626
The PR builds are still disabled on the Jenkins, however, because we need to get the build image updated.
Local builds work.
>Can we split remaining builds into multiple rows so we get badges for 1.x and 2.x?
yeah - I think that's fine. The 1.x builds were unaffected by the issue above and still work ok.
|
Thanks @jayfurmanek and @hrw. Can you also comment on the "Support" sections on the ownership table? I figure we may want different policies for users with "the build links are broken" issues (handled by the owners) vs. "the artifacts don't work for my machine" issues. So that section could e.g. be "send an email to [user]" or "file ticket to [tracker]". What do you think? |
The AMD nightly build pointer is up-to-date (build is failing, but should get back to passing once all outstanding PRs are merged) and the owners table is accurate.
The Stable Releases links for both v1 and v2 are stale, and need to be refreshed. I will follow up on this next week.
yes please. I can do that when I submit the PR to update the Stable Release links next week. |
This comment has been minimized.
This comment has been minimized.
In the interest of unblocking, I'll merge this as-is, update the main README, and file an issue here with the remaining things to do. |
This PR pulls the Community Builds table from tensorflow/tensorflow into SIG Build, and rearranges it for easier maintenance. Specifically:
Before this gets merged, I need to get ~90% confirmation that the owners are correct, broken links will be fixed, and that the way this is laid out is OK with everyone. In a comment below I'll tag everyone to ask specific questions.
Check the "build-table" branch linked above to see the new page in action.