Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TensorFlow community-builds table #24

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Migrate TensorFlow community-builds table #24

merged 1 commit into from
Apr 26, 2021

Conversation

angerson
Copy link
Contributor

@angerson angerson commented Apr 9, 2021

This PR pulls the Community Builds table from tensorflow/tensorflow into SIG Build, and rearranges it for easier maintenance. Specifically:

  • I added explicit owners + contact columns
  • I alphabetized the list
  • I shortened a couple long names

Before this gets merged, I need to get ~90% confirmation that the owners are correct, broken links will be fixed, and that the way this is laid out is OK with everyone. In a comment below I'll tag everyone to ask specific questions.

Check the "build-table" branch linked above to see the new page in action.

@angerson angerson requested a review from perfinion as a code owner April 9, 2021 18:36
@angerson
Copy link
Contributor Author

angerson commented Apr 9, 2021

FYI @lamberta @wolffg

  • @deven-amd Can you confirm the AMD builds are up-to-date and the owners table is correct?
    • The Stable Release v1 link was last built over a year ago and the v2 link 404s.
    • Can we split into two rows so we get badges for 1.x and 2.x?
  • @wdirons @jayfurmanek Can you confirm the IBM builds are up-to-date and the owners table is correct?
    • The PPC Nightly builds are disabled and didn't pass often. Should we remove them? WIP, kept
    • The PPC v2 build hasn't run since TF 2.2, should it be removed? WIP, kept
    • Can we split remaining builds into multiple rows so we get badges for 1.x and 2.x? Done
  • @gaurides @claynerobison Can you confirm the Intel builds are up-to-date and the owners table is correct?
    • The release artifacts look like they work, but the build status badge links to the badge itself.
    • I shortened the name to just Intel OneDNN because it extended the column a lot. Is that OK?
  • @hrw @paulisaacs-linaro Can you confirm the Linaro builds are up-to-date and the owners table is correct?
    • All the links go to the place you can download artifacts, which should be good!
  • @bzhaoopenstack Can you confirm the OpenLab builds are up-to-date and the owners table is correct?
    • Stable last ran in August, for TF 2.1. Is that right?
  • @sub-mod Can you tell me how to fix the RedHat builds? The links are broken. Is the owners table correct?

@lamberta
Copy link
Member

lamberta commented Apr 9, 2021

Thanks, @angerson !
Might be worth adding a sentence and link here in the build from source guide. (We already link to SIG Build in the toc but could help funnel users who end up on that page through search.)

@sub-mod
Copy link
Contributor

sub-mod commented Apr 9, 2021

@angerson will take a look next week. the CI cluster needs a reboot.

@angerson
Copy link
Contributor Author

angerson commented Apr 9, 2021

Might be worth adding a sentence and link here in the build from source guide

Yeah, good idea. Once this PR is ready to go I'll prep the docs changes and do them at the same time.

@hrw
Copy link
Contributor

hrw commented Apr 13, 2021

@angerson links to Linaro builds are pointing into proper places. Also contact persons match.

We are at 1.5.15 / 2.4.1 / git HEAD (2.6.0).

@jayfurmanek
Copy link
Contributor

jayfurmanek commented Apr 13, 2021 via email

@angerson
Copy link
Contributor Author

Thanks @jayfurmanek and @hrw. Can you also comment on the "Support" sections on the ownership table? I figure we may want different policies for users with "the build links are broken" issues (handled by the owners) vs. "the artifacts don't work for my machine" issues. So that section could e.g. be "send an email to [user]" or "file ticket to [tracker]". What do you think?

@deven-amd
Copy link
Contributor

@angerson

@deven-amd Can you confirm the AMD builds are up-to-date and the owners table is correct?

The AMD nightly build pointer is up-to-date (build is failing, but should get back to passing once all outstanding PRs are merged) and the owners table is accurate.

The Stable Release v1 link was last built over a year ago and the v2 link 404s.

The Stable Releases links for both v1 and v2 are stale, and need to be refreshed. I will follow up on this next week.

Can we split into two rows so we get badges for 1.x and 2.x?

yes please. I can do that when I submit the PR to update the Stable Release links next week.

@angerson

This comment has been minimized.

@tensorflow tensorflow deleted a comment from google-cla bot Apr 26, 2021
@tensorflow tensorflow deleted a comment from google-cla bot Apr 26, 2021
@angerson
Copy link
Contributor Author

In the interest of unblocking, I'll merge this as-is, update the main README, and file an issue here with the remaining things to do.

@angerson angerson merged commit 8b20c7a into master Apr 26, 2021
@angerson angerson deleted the build-table branch April 26, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants