-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Bazel cache for TensorFlow builds #5
Comments
I'm looking into the feasibility of providing GCP resources (likely a long-term discussion) and |
I want to just add a reference that we could need to solve this also for let the user to adopt the new Github Codespace/Vscode Remote (tensorflow/addons#1309) or for Gitpod (tensorflow/tensorflow#38755). |
It would be also nice as many SIGs builds using github Actions CI infra, specially the ones with c++/cuda custom ops, if we could find a way to recycle the bazel cache to speed-up CI builds. |
This would be excellent! For reference, some time ago there were some discussions about improving |
@lgeiger Our ticket was actions/cache#260. I don't know if they could be fused or not. |
This will be orthogonal to the approved TF modularizzation RFC |
We have started to explore internally to see if we can share our RBE cache. We will also look into if we can share a GCS cache. |
@gunan Thanks I've intercepted this candidate dup tensorflow/tensorflow#34719. Probably you can find some other ones on the TF repo. |
Yes, this has been a long running problem for TF. And as TF gets bigger it will only get worse. |
If this is going to take too much time can we find an intermediate goal like having support for python only PR? |
See what kind of bad hack I need to suggest tensorflow/tensorflow#41701 (comment) |
I've tested your initial cache inside official TF Docker devel image but it has not the cross tools (d7/d8) like RBE and custom-ops Dockerfiles/images. We have a threads in SIG-build Gitter channel |
This would be great. It is very frustrating that I have to spin up docker images and compile C++ code overnight just to test a single line of code change to a Python function. The barrier to entry to contributing is extremely high. What I often end up doing is copying |
Also when we are mounting the bazel cache inside the official Tensorflow Docker devel container we need to improve the stale cache handling. |
In the meantime can we reply to https://groups.google.com/a/tensorflow.org/g/developers/c/1OJLv2ew7pA? Is there a quick solution to iterate and modify the source code and run an example in the source dir without building and installing the wheel? |
It seems that now we have a read only cache for TF IO but still not for Tensorflow contributors: |
@bhack |
With @angerson and @perfinion we are prototyping with tensorflow/tensorflow#48421 (and #24) to continuously execute and monitor the external developer contribution experience/overhead (compile, lint and test). |
I think we could close this and monitor the build reproducibility and cache efficiency in #48 |
We have now a PR at tensorflow/tensorflow#57630 if you want to support/review/imporve this baseline. |
Providing a TensorFlow build cache could be very helpful to external developers, and lower the barrier to entry of contributing to TF.
Some ideas for this we've discussed before are:
devel_cache
Docker images containing a build cache (these could be very large)devel
images.See also:
The text was updated successfully, but these errors were encountered: