Prevent "Deleting stale sandbox base" from showing up when not necessary

[benjaminp]

What's the reason for printing the INFO: Deleting stale sandbox base /some/long/uuidy/path message? I find it non-actionable and noisy.

[thundergolfer]

⚠️ Disregard

---

As a counterpoint, I found this log-line relevant when looking into a lack of caching between our Bazel IDE plugin usage and terminal Bazel usage.

We currently find ourselves compiling com_google_protobuf over and over again because of some unwanted conflict between IDE and terminal, and seeing this log-line is I think a good hint as to what's maybe going on.

That said, the log-line might also be a red-herring, in which case disregard my comment.

[benjaminp]

Presumably you are experiencing #7095, which is unrelated to the sandbox base.

…

On Mon, Sep 23, 2019, at 18:19, Jonathon Belotti wrote: As a counterpoint, I found this log-line relevant when looking into a lack of caching between our Bazel IDE plugin usage and terminal Bazel usage. We currently find ourselves compiling `com_google_protobuf` over and over again because of some unwanted conflict between IDE and terminal, and seeing this log-line is I think a good hint as to what's maybe going on. That said, the log-line might also be a red-herring, in which case disregard my comment. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8525?email_source=notifications&email_token=AABVSTWDUZM6ZVI7FVHSVITQLFTJPA5CNFSM4HROYS4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MXP7A#issuecomment-534345724>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABVSTTB2FPZNVPXXCEEDCLQLFTJPANCNFSM4HROYS4A>.

[thundergolfer]

Thanks! Yeah this looks like a more promising lead.

I'm trying to find more info what causes 'stale' sandboxes. I don't remember seeing this log before but maybe it's new in the version of Bazel we've upgraded to.

Edit: Seems like restarting Bazel server causes it.

bazel/src/main/java/com/google/devtools/build/lib/sandbox/SandboxModule.java

Line 251 in 9ce145a

cmdEnv.getReporter().handle(Event.info("Deleting stale sandbox base " + sandboxBase));

[kylecordes]

If the answer is as simple as "restarting Bazel server causes it", and such restarts happen regularly by default (i.e. a short idle shutdown), indeed it would be great to get rid of this noisy message.

[jin]

This hasn't been a useful message to me, ever, IMO.

cc @jmmv what do you think about not showing this by default (or increasing the logging level)?

[jmmv]

The reason for the log message is that this operation could take a long time and Bazel might appear stuck.

But I don't think hiding the log message is the right thing to do here. That log message should show up in rare occasions (those where this operation might indeed take a long time). If it does show up, it's because our logic to handle the sandbox base is not doing the right thing and is leaving something behind more often than not. (At least that was the original intention of the change that added this message, but I must have gotten something wrong... and haven't had a chance to look into it again since.)

[jmmv]

@meisterT Why did you close this? I think the warning message is still annoying and we should do something about it. See my latest reply.

[meisterT]

Sorry, I understood that you already only show the message when necessary and consider it useful.