add reserve coin limit amount spec #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dongsam
commented
Feb 25, 2021
•
dongsam
commented
- spec
- implementation
- test code
5 tasks
Codecov Report
@@ Coverage Diff @@
## develop-milestone2 #117 +/- ##
======================================================
- Coverage 80.11% 77.55% -2.57%
======================================================
Files 18 18
Lines 1836 2018 +182
======================================================
+ Hits 1471 1565 +94
- Misses 192 257 +65
- Partials 173 196 +23
Continue to review full report at Codecov.
|
dongsam
changed the title
dongsam
added a commit
that referenced
this pull request
Feb 27, 2021
* remove redundant code block * add handler test for bad messages * remove fmt.Printlns for temporary debug purpose * add tests and testcases * fix typo in error name and error message * add more tests for msgs increase test coverage for msgs.go to 100% * add test case for bad swap execution also create AddRandomTestAddr test helper function * add reserve coin limit amount spec (#117) * add reserve token limit amount spec * refactoring minOfferCoinAmount naming * add ReserveCoinLimitAmount params * Add ReserveCoinLimit logic and testcodes * go fmt * fix swapPrice invariant logic * remove useless assignment * remove redundant verify logic * remove unused argument Co-authored-by: dongsam <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.