Add simulation #108
Add simulation #108
Conversation
Codecov Report
@@ Coverage Diff @@
## develop-milestone2 #108 +/- ##
=======================================================
- Coverage 80.11% 61.05% -19.07%
=======================================================
Files 18 26 +8
Lines 1836 3035 +1199
=======================================================
+ Hits 1471 1853 +382
- Misses 192 980 +788
- Partials 173 202 +29
Continue to review full report at Codecov.
|
defihyung
force-pushed
the
brandon/add-simulation
branch
from
7ade359 to
17f1f55
Compare
defihyung
force-pushed
the
brandon/add-simulation
branch
from
17f1f55 to
0a4b447
Compare
- normal scenario
defihyung
force-pushed
the
brandon/add-simulation
branch
from
e6511d6 to
5948344
Compare
|
@dongsam reviewed and we discussed offline and received great feedback about how this should be designed and improved in a way to simulate hundreds and thoudsands of simulated tests. It's ready for another review now. |
There was a problem hiding this comment.
Thanks for the work!
It looks good to me 👍
could you please apply comments and add commands for simulation on Makefile like this with sim_test.go on liquidity/app/ for to run independent simulation tests.
After the review, I think it would be helpful not to use force-push as much as possible.
… with fee denoms to simulated accounts
# Conflicts: # x/liquidity/types/utils_test.go
…oms instead of creating new denoms
- update randomDepositCoin to have up to 1e9 values - update randomWithdrawCoin to have way smaller amounts (balance divided by 10) - update weights - update tests
…/liquidity into brandon/add-simulation
|
The following issues will be tackled in the other PRs.
|
Add simulation package
Random proposal contents - this is not needed for liquidity moduleUpdate
The following issues will be tackled in the other PRs.
UnitBatchSizefor the simulation tests Randomize UnitBatchSize in genesis for the simulation #130test-sim-import-exportbug Fix test-sim-import-export simulation bug #129