Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add examples of multiple coins for command-line interfaces #156

Merged
merged 12 commits into from
Oct 8, 2021
Merged

feat: add examples of multiple coins for command-line interfaces #156

merged 12 commits into from
Oct 8, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 5, 2021 •
edited
Loading

Description

closes: #155

Tasks

  • Add NewUnstakeCmd() multiple coins example and add test case for it
  • Add NewStakeCmd() multiple coins example and add test case for it
  • Add NewHarvestCmd() more examples and add test cases for it
  • Add more description on NewAdvanceEpochCmd()
  • Update the link in the description to point to the correct location

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Oct 5, 2021
@jaybxyz jaybxyz marked this pull request as ready for review October 7, 2021 07:48
@jaybxyz jaybxyz requested review from dongsam and hallazzang October 7, 2021 07:49
@jaybxyz jaybxyz requested a review from hallazzang October 7, 2021 09:37
hallazzang
hallazzang approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongsam
dongsam approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaybxyz jaybxyz merged commit f994143 into tendermint:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallazzang hallazzang hallazzang approved these changes

@dongsam dongsam dongsam approved these changes

Assignees

@jaybxyz jaybxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add examples of multiple coins for command-line interfaces
3 participants
@jaybxyz @dongsam @hallazzang