Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate value of the name field in plan #150

Merged
merged 6 commits into from
Oct 6, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 1, 2021

Description

closes: #144

Tasks

  • Remove name validation
  • Update related documents
  • Rename name field to title for clarity (This brings confusion with gov proposal content title)
  • Update swagger

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Oct 1, 2021
# Conflicts:
#	x/farming/keeper/msg_server.go
#	x/farming/keeper/proposal_handler.go
#	x/farming/types/genesis.go
#	x/farming/types/plan.go
#	x/farming/types/plan_test.go
@jaybxyz jaybxyz marked this pull request as ready for review October 5, 2021 06:30
@jaybxyz jaybxyz requested review from dongsam and hallazzang October 5, 2021 06:42
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaybxyz jaybxyz merged commit d70949c into tendermint:master Oct 6, 2021
jaybxyz added a commit to jaybxyz/farming that referenced this pull request Oct 6, 2021
* master:
  fix: duplicate value of the name field in plan (tendermint#150)
  test: uncomment two simulation jobs in workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: duplicate value of the name field in plan
2 participants