Feature/gcp id update sp #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-phansalkar-189
requested review from
Avanti19,
gaurav-gogia and
harkirat22
|
Kudos, SonarCloud Quality Gate passed!
|
gaurav-gogia
suggested changes
May 28, 2021
|
Hey can you send an example for a change ?
…On Fri, 28 May 2021, 2:05 pm Gaurav Gogia, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@shreyas-phansalkar-189 <https://github.com/shreyas-phansalkar-189>
We have to add id field and make any necessary changes to category &
severity, we don't have to change the reference_id field here.
So, please make the changes accordingly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#814 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATCBC5YLPRN4KTU2NLEIAP3TP5ITRANCNFSM45QX7QEQ>
.
|
|
Yes, please use the changes of this pr as a reference. |
|
After some discussion, it was decided that it'll best to create a new PR due to number of conflicting files. Closing this PR in favour of PR 824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Rule Reference Id's