Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID Field for GCP Policies' Metadata #824

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Add ID Field for GCP Policies' Metadata #824

merged 1 commit into from
Jun 1, 2021

Conversation

gaurav-gogia
Copy link
Contributor

@gaurav-gogia gaurav-gogia commented May 31, 2021

Changes for terrascan policies where names match with SIAC policies

These changes are relevant only for GCP policies

  1. Add id field with new format
  2. Update severity
  3. Update category

PR created for issue #805

@gaurav-gogia gaurav-gogia self-assigned this May 31, 2021
@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label May 31, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #824 (f714e3e) into master (eff166f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   75.00%   75.00%           
=======================================
  Files         111      111           
  Lines        3404     3404           
=======================================
  Hits         2553     2553           
  Misses        663      663           
  Partials      188      188           

Copy link
Contributor

@harkirat22 harkirat22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav-gogia gaurav-gogia merged commit 0d8bc97 into tenable:master Jun 1, 2021
@gaurav-gogia gaurav-gogia deleted the feature/gcp_id_field branch June 1, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants