Support newer format versions for terraform JSON plan #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions feat: support format_version in json plan for new versions
As decoratedName in SARIF report
…urce-address Add support to report resource id
Some large files may take longer than 100ms. It also fixes a wrong log message, only in this file, there are more in other parts of the project.
Some large files may take longer than 100ms.
It also fixes a wrong log message, only in this file, there are more in
other parts of the project.
Before that:
```
❯ terrascan scan -i tfplan -f large.tfplan.json
2024-08-30T10:30:07.848+0200 warn utils/jqhelper.go:56 error in processing jq query; error: '%v'context deadline exceeded
2024-08-30T10:30:07.848+0200 error cli/run.go:141 scan run failed{error 26 0 failed to decode processed jq output. error: 'unexpected end of JSON input'}
```
*Note the wrong log message*
Increase the timeout to 1s it works.
This PR adds the `resource_type` field from the rule metadata to the output of passed rules, and further to the rule properties in the Sarif report. This field is useful to know which resource rules were applied to, in particular for rules without violations where we have no way of knowing this otherwise.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format versions currently supported by Terrascan are very outdated (since Terraform 1.1.x). This PR adds support for the newer versions.
This was already tested and confirm not to break Terrascan functionality.