Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wait longer to process JQ query #3

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

sixstone-qq
Copy link

Some large files may take longer than 100ms.

It also fixes a wrong log message, only in this file, there are more in other parts of the project.

Before that:

❯ terrascan scan -i tfplan -f large.tfplan.json
2024-08-30T10:30:07.848+0200    warn    utils/jqhelper.go:56    error in processing jq query; error: '%v'context deadline exceeded
2024-08-30T10:30:07.848+0200    error   cli/run.go:141  scan run failed{error 26 0  failed to decode processed jq output. error: 'unexpected end of JSON input'}

Note the wrong log message

Increase the timeout to 1s it works.

Some large files may take longer than 100ms.

It also fixes a wrong log message, only in this file, there are
more in other parts of the project.
Copy link

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sixstone-qq sixstone-qq merged commit 0b185f0 into master Aug 30, 2024
@sixstone-qq sixstone-qq deleted the sixstone-qq/001/sc-13611-scan-large-files branch August 30, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants