Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context propagators to local activity executions through test environments #1291

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add context propagators to local activity executions through test environments #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7be598
Add context propagators to the local activity task handler
DeRauk Nov 8, 2023
b7fa303
Add test
DeRauk Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions internal/internal_workflow_testsuite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,7 @@ func (env *testWorkflowEnvironmentImpl) executeLocalActivity(
ActivityFn: activityFn,
InputArgs: args,
WorkflowInfo: env.workflowInfo,
Header: env.header,
}
task := &localActivityTask{
activityID: "test-local-activity",
Expand All @@ -648,12 +649,14 @@ func (env *testWorkflowEnvironmentImpl) executeLocalActivity(
},
attempt: 1,
scheduledTime: time.Now(),
header: params.Header,
}
taskHandler := localActivityTaskHandler{
userContext: env.workerOptions.BackgroundActivityContext,
metricsHandler: env.metricsHandler,
logger: env.logger,
interceptors: env.registry.interceptors,
userContext: env.workerOptions.BackgroundActivityContext,
metricsHandler: env.metricsHandler,
logger: env.logger,
interceptors: env.registry.interceptors,
contextPropagators: env.contextPropagators,
}

result := taskHandler.executeLocalActivityTask(task)
Expand Down
26 changes: 26 additions & 0 deletions internal/internal_workflow_testsuite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2391,6 +2391,32 @@ func (s *WorkflowTestSuiteUnitTest) Test_WorkflowLocalActivityWithMockAndListene
s.True(localActivityFnCanceled.Load())
}

func (s *WorkflowTestSuiteUnitTest) Test_LocalActivityWithHeaderContext() {
// inline activity using value passing through user context.
activityWithUserContext := func(ctx context.Context) (string, error) {
value := ctx.Value(contextKey(testHeader))
if val, ok := value.(string); ok {
return val, nil
}
return "", errors.New("value not found from ctx")
}

env := s.NewTestActivityEnvironment()
env.SetHeader(&commonpb.Header{
Fields: map[string]*commonpb.Payload{
testHeader: encodeString(s.T(), "test-data"),
},
})
env.SetContextPropagators([]ContextPropagator{NewKeysPropagator([]string{testHeader})})

env.RegisterActivity(activityWithUserContext)
blob, err := env.ExecuteLocalActivity(activityWithUserContext)
s.NoError(err)
var value string
_ = blob.Get(&value)
s.Equal("test-data", value)
}

func (s *WorkflowTestSuiteUnitTest) Test_SignalChildWorkflow() {
// This test will send signal from parent to child, and then child will send back signal to ack. No mock is needed.
signalName := "test-signal-name"
Expand Down
Loading