Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context propagators to local activity executions through test environments #1291

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add context propagators to local activity executions through test environments #1291

merged 2 commits into from
Nov 8, 2023

Conversation

DeRauk
Copy link
Contributor

@DeRauk DeRauk commented Nov 8, 2023

What was changed

Add context propagators when executing a local activity in a test environment.

Why?

Fix for the linked issue

Checklist

  1. Closes Context propagators aren't used when running local activities with the test environments #1290

  2. How was this tested:
    A unit test was added

  3. Any docs updates needed?
    Nope

@DeRauk DeRauk requested a review from a team as a code owner November 8, 2023 16:22
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 0e432a9 into temporalio:master Nov 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context propagators aren't used when running local activities with the test environments
3 participants
@DeRauk @CLAassistant @Quinn-With-Two-Ns