Update config.js: tls.rejectUnauthorized false by default (for selfsigned certificates) #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroVega
changed the title
fgalan
reviewed
Jun 27, 2018
| @@ -119,6 +119,12 @@ config.smtp = { | |||
| pass: 'xyz' | |||
| } | |||
| */ | |||
| , | |||
| tls: { | |||
There was a problem hiding this comment.
Should the new option be document in some .md? (not sure to which level of deatil we are describing configuration in .mds... to be checked)
AlvaroVega
changed the title
fgalan
reviewed
Jun 27, 2018
| @@ -24,6 +24,7 @@ The following table shows the environment variables available for Perseo configu | |||
| | PERSEO_SMTP_SECURE | `true` if SSL should be used with the SMTP server | | |||
| | PERSEO_SMTP_AUTH_USER | Authentication data, the username | | |||
| | PERSEO_SMTP_AUTH_PASS | Authentication data, the password for the user | | |||
| | PERSEO_SMTP_TLS_REJECTUNAUTHORIZED | Reject if unauthorized security is found (i.e. selfsigned certificates). Default is false. | | |||
There was a problem hiding this comment.
FYI @cesarjorgemartinez a new env var is being created by this PR. Take it into account in ansible, etc.
NTC (informative)
fgalan
reviewed
Jun 27, 2018
CHANGES_NEXT_RELEASE
Outdated
| @@ -1 +1,2 @@ | |||
| - Using precise dependencies (~=) in packages.json | |||
| - Provide default value (false) for tls.rejectUnauthorized config option | |||
There was a problem hiding this comment.
Is this PR related with #272? To mention the issue number in that case in the CNR line...
There was a problem hiding this comment.
It's a part for this issue, pending ignoreTLS/requireTLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.