Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TLS options in smtp config section #272

Closed
cesarjorgemartinez opened this issue Jun 19, 2018 · 4 comments
Closed

Missing TLS options in smtp config section #272

cesarjorgemartinez opened this issue Jun 19, 2018 · 4 comments

Comments

@cesarjorgemartinez
Copy link
Contributor

Missing TLS options in smtp config section

In https://github.com/telefonicaid/perseo-fe/blob/master/config.js, not use TLS options

See:
http://nodemailer.com/smtp/

@cesarjorgemartinez
Copy link
Contributor Author

TLS options

secure – if true the connection will use TLS when connecting to server. If false (the default) then TLS is used if server supports the STARTTLS extension. In most cases set this value to true if you are connecting to port 465. For port 587 or 25 keep it false
tls – defines additional node.js TLSSocket options to be passed to the socket constructor, eg. {rejectUnauthorized: true}.
ignoreTLS – if this is true and secure is false then TLS is not used even if the server supports STARTTLS extension
requireTLS – if this is true and secure is false then Nodemailer tries to use STARTTLS even if the server does not advertise support for it. If the connection can not be encrypted then message is not sent

@fgalan
Copy link
Member

fgalan commented Jun 28, 2018

Parcially addressed (tls option) in PR #275.

secure is already implemented. ignoreTLS and requireTLS would be defered to a next PR

@fgalan fgalan modified the milestone: 1.6.0 Jun 28, 2018
@AlvaroVega
Copy link
Member

smtp options from nodemailer-smtp-transport dep used by persieo according with https://github.com/nodemailer/nodemailer-smtp-transport/tree/v2.7.2 are:

options.port is the port to connect to (defaults to 25 or 465)
options.host is the hostname or IP address to connect to (defaults to 'localhost')
options.secure defines if the connection should use SSL (if true) or not (if false)
options.auth defines authentication data (see authentication section below)
options.ignoreTLS turns off STARTTLS support if true
options.name optional hostname of the client, used for identifying to the server
options.localAddress is the local interface to bind to for network connections
options.connectionTimeout how many milliseconds to wait for the connection to establish
options.greetingTimeout how many milliseconds to wait for the greeting after connection is established
options.socketTimeout how many milliseconds of inactivity to allow
options.logger optional bunyan compatible logger instance. If set to true then logs to console. If value is not set or is false then nothing is logged
options.debug if set to true, then logs SMTP traffic, otherwise logs only transaction events
options.authMethod defines preferred authentication method, eg. 'PLAIN'
options.tls defines additional options to be passed to the socket constructor, eg. {rejectUnauthorized: true}
getSocket optional method that is called every time a new connection is made against the SMTP server. This method can provide an existing socket to be used instead of creating a new one

@AlvaroVega
Copy link
Member

Now nodemailer dep has been updated recently.
Now each email rule support their own smtp configuration.
So we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants