Add Namespaced Scope Interceptor #1462

khrm · 2022-10-12T07:17:20Z

Added Namespaced Scope Interceptor. A namespaced admin can create and manage its interceptor without requiring elevated permissions. Fixes #1364

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

`Interceptor` CRD has been added which can be used to define NamespacedScope Interceptor. Use NamespacedInterceptor in kind section of Interceptors Ref in Triggers or EventListener spec.

khrm

/hold

tekton-robot · 2022-10-12T07:21:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%

tekton-robot · 2022-10-12T10:58:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	61.4%	-11.7

tekton-robot · 2022-10-12T11:08:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	61.4%	-11.7

tekton-robot · 2022-10-12T18:04:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	61.4%	-11.7

tekton-robot · 2022-10-12T18:13:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	61.4%	-11.7

tekton-robot · 2022-10-12T18:34:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	69.7%	-3.4

khrm · 2022-10-13T05:48:58Z

/hold cancel

tekton-robot · 2022-10-13T05:49:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	72.0%	-1.1
test/controller.go	71.8%	70.5%	-1.3

khrm · 2022-10-13T06:31:24Z

/test pull-tekton-triggers-integration-tests

khrm

/kind feature

tekton-robot · 2022-10-13T09:58:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	72.0%	-1.1
test/controller.go	71.8%	70.5%	-1.3

tekton-robot · 2022-10-13T14:10:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.1%	72.0%	-1.1
test/controller.go	71.8%	70.5%	-1.3

tekton-robot · 2022-11-10T01:53:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go	66.7%	90.9%	24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.0%	72.0%	-1.0
test/controller.go	71.8%	70.5%	-1.3

pkg/client/dynamic/clientset/tekton/tekton.go

dibyom

The code looks fine, but I think we should add examples and docs before the release

If a clusterinterceptor and interceptor have the same name, which one is used?

pkg/client/dynamic/clientset/tekton/tekton.go

khrm · 2022-11-11T05:24:00Z

If a clusterinterceptor and interceptor have the same name, which one is used?

I didn't get this. Which place are you talking about? We specify InterceptorKind in the ref.

dibyom · 2022-11-11T15:07:10Z

Is InterceptorKind a required field now? And does it default to ClusterInterceptor?

khrm · 2022-11-11T16:36:14Z

It's still optional. By default, it is ClusterInterceptor.

Added documentation. I will add examples soon.

tekton-robot · 2022-11-11T16:37:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go	66.7%	90.9%	24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.0%	72.0%	-1.0
test/controller.go	71.8%	70.5%	-1.3

dibyom · 2022-11-11T16:45:06Z

It's still optional. By default, it is ClusterInterceptor.

got it, that makes sense!

khrm · 2022-11-11T18:04:05Z

I will add the example on Monday.

dibyom

/approve

tekton-robot · 2022-11-11T18:20:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

docs/namespacedinterceptors.md

tekton-robot · 2022-11-14T08:13:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go	66.7%	90.9%	24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.0%	72.0%	-1.0
test/controller.go	71.8%	70.5%	-1.3

Added Namespaced Scope Interceptor. A namespaced admin can create and manage its interceptor without requiring elevated permissions. Fixes #1364

tekton-robot · 2022-11-14T09:37:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go	66.7%	90.9%	24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.0%	72.0%	-1.0
test/controller.go	71.8%	70.5%	-1.3

tekton-robot · 2022-11-14T17:37:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go	66.7%	90.9%	24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.0%	72.0%	-1.0
test/controller.go	71.8%	70.5%	-1.3

khrm · 2022-11-14T17:41:14Z

@savitaashture I have added the example. Please review and add LGTM.

Example utilizes Core Interceptor from v0.19 Triggers.

tekton-robot · 2022-11-15T05:57:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/adapter.go	28.8%	23.5%	-5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go	Do not exist	0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go	66.7%	90.9%	24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go	Do not exist	100.0%
pkg/reconciler/interceptor/controller.go	Do not exist	0.0%
pkg/reconciler/interceptor/interceptor.go	Do not exist	90.9%
pkg/sink/sink.go	73.0%	72.0%	-1.0
test/controller.go	71.8%	70.5%	-1.3

examples/v1alpha1/namespacedinterceptor/interceptors-deployment.yaml

savitaashture · 2022-11-15T09:18:47Z

/lgtm

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 12, 2022

tekton-robot requested review from bobcatfish and ncskier October 12, 2022 07:17

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 12, 2022

khrm commented Oct 12, 2022

View reviewed changes

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022

khrm force-pushed the f/NSInterceptor branch from 0e26478 to 4828889 Compare October 12, 2022 10:57

khrm force-pushed the f/NSInterceptor branch from 4828889 to 199d804 Compare October 12, 2022 11:07

khrm force-pushed the f/NSInterceptor branch from 199d804 to ebad433 Compare October 12, 2022 18:02

khrm force-pushed the f/NSInterceptor branch from ebad433 to 8c43fb6 Compare October 12, 2022 18:10

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 12, 2022

khrm force-pushed the f/NSInterceptor branch from 8c43fb6 to f7cf3c6 Compare October 12, 2022 18:31

khrm force-pushed the f/NSInterceptor branch from f7cf3c6 to c7156a3 Compare October 13, 2022 05:46

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2022

khrm commented Oct 13, 2022

View reviewed changes

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 13, 2022

khrm force-pushed the f/NSInterceptor branch from c7156a3 to 4b9bcd9 Compare October 13, 2022 09:55

khrm force-pushed the f/NSInterceptor branch from 4b9bcd9 to 76a9c5c Compare October 13, 2022 14:07

savitaashture reviewed Nov 10, 2022

View reviewed changes

pkg/client/dynamic/clientset/tekton/tekton.go Show resolved Hide resolved

dibyom approved these changes Nov 10, 2022

View reviewed changes

pkg/client/dynamic/clientset/tekton/tekton.go Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022

dibyom reviewed Nov 11, 2022

View reviewed changes

savitaashture reviewed Nov 14, 2022

View reviewed changes

docs/namespacedinterceptors.md Outdated Show resolved Hide resolved

khrm force-pushed the f/NSInterceptor branch from 7ead05d to b79e0a6 Compare November 14, 2022 08:11

khrm added 2 commits November 14, 2022 15:04

Add Namespaced Scope Interceptor

ab7d9f5

Added Namespaced Scope Interceptor. A namespaced admin can create and manage its interceptor without requiring elevated permissions. Fixes #1364

Add Documentation for NamespacedInterceptor

c165271

khrm force-pushed the f/NSInterceptor branch from b79e0a6 to c165271 Compare November 14, 2022 09:35

Add Example for NamespacedInterceptor

2d31171

Example utilizes Core Interceptor from v0.19 Triggers.

khrm force-pushed the f/NSInterceptor branch from 315196d to 2d31171 Compare November 15, 2022 05:55

savitaashture reviewed Nov 15, 2022

View reviewed changes

examples/v1alpha1/namespacedinterceptor/interceptors-deployment.yaml Show resolved Hide resolved

tekton-robot assigned savitaashture Nov 15, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022

tekton-robot merged commit b4a404d into main Nov 15, 2022

khrm deleted the f/NSInterceptor branch February 28, 2023 04:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Namespaced Scope Interceptor #1462

Add Namespaced Scope Interceptor #1462

khrm commented Oct 12, 2022 •

edited

Loading

khrm left a comment

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

khrm commented Oct 13, 2022

tekton-robot commented Oct 13, 2022

khrm commented Oct 13, 2022

khrm left a comment

tekton-robot commented Oct 13, 2022

tekton-robot commented Oct 13, 2022

tekton-robot commented Nov 10, 2022

dibyom left a comment

khrm commented Nov 11, 2022

dibyom commented Nov 11, 2022

khrm commented Nov 11, 2022

tekton-robot commented Nov 11, 2022

dibyom commented Nov 11, 2022

khrm commented Nov 11, 2022

dibyom left a comment

tekton-robot commented Nov 11, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

khrm commented Nov 14, 2022 •

edited

Loading

tekton-robot commented Nov 15, 2022

savitaashture commented Nov 15, 2022

Add Namespaced Scope Interceptor #1462

Add Namespaced Scope Interceptor #1462

Conversation

khrm commented Oct 12, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

khrm left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

tekton-robot commented Oct 12, 2022

khrm commented Oct 13, 2022

tekton-robot commented Oct 13, 2022

khrm commented Oct 13, 2022

khrm left a comment

Choose a reason for hiding this comment

tekton-robot commented Oct 13, 2022

tekton-robot commented Oct 13, 2022

tekton-robot commented Nov 10, 2022

dibyom left a comment

Choose a reason for hiding this comment

khrm commented Nov 11, 2022

dibyom commented Nov 11, 2022

khrm commented Nov 11, 2022

tekton-robot commented Nov 11, 2022

dibyom commented Nov 11, 2022

khrm commented Nov 11, 2022

dibyom left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 11, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

tekton-robot commented Nov 14, 2022

khrm commented Nov 14, 2022 • edited Loading

tekton-robot commented Nov 15, 2022

savitaashture commented Nov 15, 2022

khrm commented Oct 12, 2022 •

edited

Loading

khrm commented Nov 14, 2022 •

edited

Loading