-
Notifications
You must be signed in to change notification settings - Fork 422
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added Namespaced Scope Interceptor. A namespaced admin can create and manage its interceptor without requiring elevated permissions. Fixes #1364
- Loading branch information
Showing
34 changed files
with
2,796 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Copyright 2022 The Tekton Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: interceptors.triggers.tekton.dev | ||
| labels: | ||
| app.kubernetes.io/instance: default | ||
| app.kubernetes.io/part-of: tekton-triggers | ||
| triggers.tekton.dev/release: "devel" | ||
| version: "devel" | ||
| spec: | ||
| group: triggers.tekton.dev | ||
| scope: Cluster | ||
| names: | ||
| kind: Interceptor | ||
| plural: interceptors | ||
| singular: interceptor | ||
| shortNames: | ||
| - ni | ||
| categories: | ||
| - tekton | ||
| - tekton-triggers | ||
| versions: | ||
| - name: v1alpha1 | ||
| served: true | ||
| storage: true | ||
| schema: | ||
| openAPIV3Schema: | ||
| type: object | ||
| # One can use x-kubernetes-preserve-unknown-fields: true | ||
| # at the root of the schema (and inside any properties, additionalProperties) | ||
| # to get the traditional CRD behaviour that nothing is pruned, despite | ||
| # setting spec.preserveUnknownProperties: false. | ||
| # | ||
| # See https://kubernetes.io/blog/2019/06/20/crd-structural-schema/ | ||
| # See issue: https://github.com/knative/serving/issues/912 | ||
| x-kubernetes-preserve-unknown-fields: true | ||
| # Opt into the status subresource so metadata.generation | ||
| # starts to increment | ||
| subresources: | ||
| status: {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* | ||
| Copyright 2022 The Tekton Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "context" | ||
| ) | ||
|
|
||
| // SetDefaults sets the defaults on the object. | ||
| func (it *Interceptor) SetDefaults(ctx context.Context) {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| Copyright 2022 The Tekton Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "knative.dev/pkg/apis" | ||
| ) | ||
|
|
||
| // Validate Interceptor | ||
| func (it *Interceptor) Validate(ctx context.Context) *apis.FieldError { | ||
| if apis.IsInDelete(ctx) { | ||
| return nil | ||
| } | ||
| return it.Spec.validate(ctx) | ||
| } | ||
|
|
||
| func (s *InterceptorSpec) validate(ctx context.Context) (errs *apis.FieldError) { | ||
| if s.ClientConfig.URL != nil && s.ClientConfig.Service != nil { | ||
| errs = errs.Also(apis.ErrMultipleOneOf("spec.clientConfig.url", "spec.clientConfig.service")) | ||
| } | ||
| if svc := s.ClientConfig.Service; svc != nil { | ||
| if svc.Namespace == "" { | ||
| errs = errs.Also(apis.ErrMissingField("spec.clientConfig.service.namespace")) | ||
| } | ||
| if svc.Name == "" { | ||
| errs = errs.Also(apis.ErrMissingField("spec.clientConfig.service.name")) | ||
| } | ||
| } | ||
| return errs | ||
| } |
Oops, something went wrong.