Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly tests for cli, triggers & operator on ppc64le architecture #786

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

svghadi
Copy link
Contributor

@svghadi svghadi commented Mar 19, 2021

Changes

This PR adds nightly e2e tests on ppc64le architecture for cli, triggers & operator. Nightly pipeline tests on ppc64le hardware is already enabled via #762.

/kind feature
/cc @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot requested a review from afrittoli March 19, 2021 07:25
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2021
@tekton-robot
Copy link
Contributor

Hi @Siddhesh-Ghadi. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 19, 2021
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2021
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we did not duplicate common deploy and cleanup script between bastion-z and bastion-p (and more architectures in future.
These deploy tasks are already duplicating logic which is release pipeline of the respective repo, it will become hard to maintain if we copy it many times.

I guess it's ok to do it for now, but I really would prefer if eventually we used the nightly build to run the tests, which would allow us to know whether the nightly build works or not.

In fact we could get rid of the extra cronjob, and define a trigger that catches the completion of a nightly release to start the tests.

/cc @barthy1

/lgtm

@tekton-robot
Copy link
Contributor

@afrittoli: GitHub didn't allow me to request PR reviews from the following users: barthy1.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

I would prefer we did not duplicate common deploy and cleanup script between bastion-z and bastion-p (and more architectures in future.
These deploy tasks are already duplicating logic which is release pipeline of the respective repo, it will become hard to maintain if we copy it many times.

I guess it's ok to do it for now, but I really would prefer if eventually we used the nightly build to run the tests, which would allow us to know whether the nightly build works or not.

In fact we could get rid of the extra cronjob, and define a trigger that catches the completion of a nightly release to start the tests.

/cc @barthy1

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@tekton-robot tekton-robot merged commit 4823ac9 into tektoncd:main Mar 23, 2021
@svghadi svghadi deleted the PR branch August 30, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants