-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly tests for cli, triggers & operator on ppc64le architecture #786
Conversation
Hi @Siddhesh-Ghadi. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Siddhesh Ghadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @afrittoli
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we did not duplicate common deploy and cleanup script between bastion-z and bastion-p (and more architectures in future.
These deploy tasks are already duplicating logic which is release pipeline of the respective repo, it will become hard to maintain if we copy it many times.
I guess it's ok to do it for now, but I really would prefer if eventually we used the nightly build to run the tests, which would allow us to know whether the nightly build works or not.
In fact we could get rid of the extra cronjob, and define a trigger that catches the completion of a nightly release to start the tests.
/cc @barthy1
/lgtm
@afrittoli: GitHub didn't allow me to request PR reviews from the following users: barthy1. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
This PR adds nightly e2e tests on
ppc64le
architecture forcli
,triggers
&operator
. Nightlypipeline
tests on ppc64le hardware is already enabled via #762./kind feature
/cc @afrittoli
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.