Add pipelines nightly tests for ppc64le architecture #762
Conversation
tekton-robot
added
the
kind/feature
|
|
tekton-robot
added
the
needs-ok-to-test
|
Hi @Siddhesh-Ghadi. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
size/L
|
/ok-to-test |
tekton-robot
added
ok-to-test
- Add secret & resource details to docs. - Update nightly test EventListener to include ppc64le architecture. - Add TriggerTemplate for nightly pipeline tests on ppc64le. - Add cronjob to trigger nightly ppc64le pipeline tests. - Add tasks to deploy, test & clean pipeline components on remote ppc64le cluster. - Add service account for triggering nightly tests. Signed-off-by: Siddhesh Ghadi <[email protected]>
|
Hi @afrittoli, is there anything else needed for this to be merged ? |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| - | | ||
| # busybox binary in distroless image doesn't work on ppc64le | ||
| # https://bugs.busybox.net/show_bug.cgi?id=13491 | ||
| sed -i 's/gcr.io\/distroless\/base@sha256:[a-zA-Z0-9]*/registry.access.redhat.com\/ubi8\/ubi-minimal:latest/g' config/controller.yaml |
There was a problem hiding this comment.
This is for the shell image, right?
There was a problem hiding this comment.
Yes, it is. Even though distroless/base image is available for ppc64le , the busybox binary present in the image is for big endian ppc machines and fails on ppc64le(which is little endian). We are working on having a permanent fix via using debian based busybox incorporated in distroless image.
There was a problem hiding this comment.
Posted on that distroless PR too - GoogleContainerTools/distroless#622 (comment) checking if debian repo way to install ppc64le based busybox can be option in distroless/base image .
There was a problem hiding this comment.
That's great, thank you!
This means that the nightly / full releases we produce for ppc64le are somewhat broken, right?
Do we have an issue to track this on tekton side? We could have a separate image / release file for ppc64le, or we could wait until we have a working busybox, but it would be good to document that it's not working for now?
There was a problem hiding this comment.
This means that the nightly / full releases we produce for ppc64le are somewhat broken, right?
Yes, since we have to replace distroless with ubi, we can say its broken for ppc64le.
Do we have an issue to track this on tekton side?
I have created tektoncd/pipeline#3820 to track this.
Hey, I think we already discussed it somewhere. That can be next step in my todo list for s390x (still, I'd prefer 2 tests :) ) |
This PR is similar to #663. It adds
cronjob,tasks&service accountto run nightly pipeline tests on remoteppc64lecluster.The job configurations expect following resources to be present on dogfooding
ppc64le-kubeconfigused to access ppc64le remote k8 clusterregistry-credentialsused to access registry on remote machineregistry-certificateself-signed certificate for registry on remote machineppc64le-clusterheadless service & endpoint to resolve remote machine addressChanges
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind feature
/cc @afrittoli