Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.40.x] tekton: make sure the git workingdir is not dirty… #5583

Merged
merged 1 commit into from
Sep 30, 2022
Merged

[release-v0.40.x] tekton: make sure the git workingdir is not dirty… #5583

merged 1 commit into from
Sep 30, 2022

Commits on Sep 29, 2022

  1. tekton: make sure the git workingdir is not dirty… 

    … when building the released binaries/images.

As of today, we are modifying the source and building. This means
`knative.dev/pkg/changeset` will require the commit hash suffixed by
`-dirty`. This can be a bit confusing the users as, well, this means
the source is not really the source of truth of the binary :)

This changes that:
- it generates `.ko.yaml` in `/workspace` so that it's not in the git
  repository. It uses `KO_CONFIG_PATH` environment variable to force
  `ko` to use it.
- it does the devel->version rewrite on generated yamls, so after the
  build is done.

Signed-off-by: Vincent Demeester <[email protected]>
    @vdemeester
    vdemeester authored and tekton-robot committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b163bb1 View commit details
    Browse the repository at this point in the history