[release-v0.40.x] tekton: make sure the git workingdir is not dirty… #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when building the released binaries/images. As of today, we are modifying the source and building. This means `knative.dev/pkg/changeset` will require the commit hash suffixed by `-dirty`. This can be a bit confusing the users as, well, this means the source is not really the source of truth of the binary :) This changes that: - it generates `.ko.yaml` in `/workspace` so that it's not in the git repository. It uses `KO_CONFIG_PATH` environment variable to force `ko` to use it. - it does the devel->version rewrite on generated yamls, so after the build is done. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
the
release-note
7 tasks
tekton-robot
added
the
size/S
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5573
/assign vdemeester