Bump TestSidecarTaskSupport test timeout to 2m. #5260
Conversation
The sidecar tests have been fairly flaky. :( While in upstream we've added more compute at the prow clusters to help, this has still been noticable in other CI environments. Bumping this for the time being to help the pain. It'd probably be worth looking into if there's room for improvement for why these are taking so long to schedule.
tekton-robot
added
kind/flake
tekton-robot
added
the
size/XS
|
/cc @imjasonh |
|
Hmmmmm not sure why the release notes none aren't being picked up. Docs say this should be okay... /release-note-none |
tekton-robot
added
release-note-none
|
/lgtm Is there a space between the ` and the release-note? That's tripped me up in the past. |
That was it! Looks like #5105 should fix. 😎 |
|
unit tests failing due to #5152 |
|
/retest |
|
/approve For what it's worth, I think I tried tweaking this timeout earlier and it didn't solve the problem. But I could be confusing memories of failed attempts to get the various |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
The sidecar tests have been fairly flaky. :(
While in upstream we've added more compute at the prow clusters to
help, this has still been noticable in other CI environments.
Bumping this for the time being to help the pain. It'd probably be worth
looking into if there's room for improvement for why these are taking so
long to schedule.
/kind flake
Related: #2656
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes