-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake: TestRealRunnerStdoutAndStderr* unit tests #5152
Comments
Seeing this as well, I think it was added recently in #4882; @bradbeck would you mind taking a look at this? It might help to use a fake clock (example in taskrun reconciler tests) as opposed to a real one |
|
One fix might be to have the test wait in a loop till the file has content before comparing (with a time limit of a few seconds say) |
Took a crack at this in #5261 since this blocked one of my other PRs 🙃 - would appreciate any feedback, in particular since this is going against what a comment in the original PR said not to do (but I think it's fine anyway?) |
I've seen a couple of these fail a few times recently on CI with this output:
...and...
I have not been able to reproduce locally.
/kind flake
The text was updated successfully, but these errors were encountered: