[TEP-0075] Validate task result variable of object type #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
chuangw6
changed the title
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
2 times, most recently
from
5a4e833
to
9eb408b
Compare
|
/test tekton-pipeline-unit-tests |
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
from
9eb408b
to
e83b670
Compare
|
/test pull-tekton-pipeline-go-coverage |
lbernick
reviewed
May 17, 2022
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
from
e83b670
to
aacaa37
Compare
tekton-robot
added
size/L
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
2 times, most recently
from
da753b0
to
032f28b
Compare
lbernick
reviewed
May 18, 2022
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
2 times, most recently
from
9aa60c1
to
f55b58e
Compare
|
/assign ywluogg |
lbernick
approved these changes
May 27, 2022
tekton-robot
added
the
approved
ywluogg
reviewed
Jun 2, 2022
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
from
f55b58e
to
d16d410
Compare
ywluogg
approved these changes
Jun 2, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, ywluogg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Link this to #4723 |
|
This needs a release note. |
tekton-robot
added
the
needs-rebase
Prior to this commit, when providing param value with task result variable, it only allowed using the task result as whole in the format of `tasks.<taskName>.results.<resultName>` since result can be only of type string previously. As we are adding support for object type result, we need to support using the result variable of object type in the format of `tasks.<taskName>.results.<objectResultName>.<individualAttribute>`. In this commit, we consider the object case in the validation webhook.
chuangw6
force-pushed
the
tep75-pipeline-validation-webhook
branch
from
d16d410
to
0facd8d
Compare
tekton-robot
removed
the
needs-rebase
|
/lgtm |
|
/test tekton-pipeline-unit-tests |
|
/retest |
|
/kind feature |
tekton-robot
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this commit, when providing param value with task result
variable, it only allowed using the task result as whole in the format
of
tasks.<taskName>.results.<resultName>since result canbe only of type string previously.
As we are adding support for object type result, we need to support
using the result variable of object type in the format of
tasks.<taskName>.results.<objectResultName>.<individualAttribute>.In this commit, we consider the object case in the validation webhook.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes