Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ywluogg into Pipeline reviewer roles #737

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add ywluogg into Pipeline reviewer roles #737

merged 1 commit into from
Jun 23, 2022

Conversation

ywluogg
Copy link
Contributor

@ywluogg ywluogg commented Jun 22, 2022 •
edited
Loading

Following tektoncd contributor ladders @ywluogg has reviewed at least 15 PRs, and should be qualified to be a reviewer for Pipeline repo:

  1. #4786
  2. #4818
  3. #4835
  4. #4855
  5. #4861
  6. #4867
  7. #4872
  8. #4878
  9. #4883
  10. #4901
  11. #4904
  12. #4908
  13. #4911
  14. #4920
  15. #4965

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2022
@dibyom
Copy link
Member

dibyom commented Jun 22, 2022

Thank you for doing so many reviews for object and array params!
Not sure how feasible this is today due to the code organization but I think given's @ywluogg 's experience around parameters, we should consider making @ywluogg a maintainer for params

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
jerop
jerop approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @ywluogg!

/meow

@tekton-robot
Copy link
Contributor

@jerop: cat image

In response to this:

Thank you for your contributions @ywluogg!

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester
vdemeester approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dibyom,jerop,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit caf176a into tektoncd:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom dibyom approved these changes

@jerop jerop jerop approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ywluogg @dibyom @tekton-robot @vdemeester @jerop