-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install.md to reflect the correct installation behaviour #2187
Conversation
/release-note-none |
@divyansh42: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/install.md
Outdated
@@ -11,6 +11,7 @@ weight: 100 | |||
``` | |||
$ kubectl apply -f https://storage.googleapis.com/tekton-releases/operator/latest/release.yaml | |||
``` | |||
**Note**: This will also install pipelines, triggers, chains, and dashboard | |||
2. Install Components ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you not removing this step then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this step but anyhow we will have to specify different installation profiles.
So we can probably re-word step 2. Please let me know what you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piyush-garg I have modified step 2 a bit. PTAL.
@divyansh42 please rebase and merge as a single commit |
Fixes: tektoncd#2097 Once the operator is installed through the `release.yaml` it also installs the other components Adding a note here to avoid any confusion the user may have while following the installation steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkandasa, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes: #2097
Once the operator is installed through the
release.yaml
it also installs the other components Adding a note here to avoid any confusion the user may have while following the installation steps.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes