Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.md to reflect the correct installation behaviour #2187

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Jun 4, 2024

Changes

Fixes: #2097
Once the operator is installed through the release.yaml it also installs the other components Adding a note here to avoid any confusion the user may have while following the installation steps.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 4, 2024
@divyansh42
Copy link
Member Author

/release-note-none

@tekton-robot
Copy link
Contributor

@divyansh42: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2024
docs/install.md Outdated
@@ -11,6 +11,7 @@ weight: 100
```
$ kubectl apply -f https://storage.googleapis.com/tekton-releases/operator/latest/release.yaml
```
**Note**: This will also install pipelines, triggers, chains, and dashboard
2. Install Components (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you not removing this step then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this step but anyhow we will have to specify different installation profiles.
So we can probably re-word step 2. Please let me know what you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-garg I have modified step 2 a bit. PTAL.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 4, 2024
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@jkandasa
Copy link
Member

jkandasa commented Jun 5, 2024

@divyansh42 please rebase and merge as a single commit

Fixes: tektoncd#2097
Once the operator is installed through the `release.yaml` it also installs the other components
Adding a note here to avoid any confusion the user may have while following the installation steps.
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jkandasa,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 4c3220b into tektoncd:main Jun 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On install, conflicting components are created
5 participants