Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On install, conflicting components are created #2097

Closed
corinz opened this issue Apr 4, 2024 · 5 comments · Fixed by #2187
Closed

On install, conflicting components are created #2097

corinz opened this issue Apr 4, 2024 · 5 comments · Fixed by #2187
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@corinz
Copy link

corinz commented Apr 4, 2024

When installing the crds, and operator via release.yaml with the instructions found here, the operator launches some Tekton components.

After step 1 is completed, the instructions advise the creation of a TektonConfig, which, after applied, deletes the original components, and replaces with them with new components (pods).

If the intent is to use release.yaml with a TektonConfig, the release.yaml should not create any components by default.

I propose that release.yaml only create the CRDs and operator, without installing any components by default.

Proposal: change AUTOINSTALL_COMPONENTS env var set in the tekton-operator/tekton-config-defaults configmap be set to false by default to prevent this collision/conflict.

@piyush-garg
Copy link
Contributor

Thanks @corinz for reporting

Seems like something wrong with the value here. We need to fix the default value or need to update the doc

@piyush-garg piyush-garg added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 25, 2024
@divyansh42
Copy link
Member

/assign

@divyansh42
Copy link
Member

As per the Slack conversation, we will be doing the documentation update to reflect the current behavior.
We are not making any changes in the present behavior as it might break/confuse the existing user's flow.

@divyansh42
Copy link
Member

divyansh42 commented May 31, 2024

Hi @corinz
I am trying to reproduce the issue but I don't see pods getting re-created after applying the config. Could you check again?
I just did the two steps mentioned here

@divyansh42
Copy link
Member

However, I agree with your point that the first step also installs the Tekton components

divyansh42 added a commit to divyansh42/operator that referenced this issue Jun 4, 2024
Fixes: tektoncd#2097
Once the operator is installed through the `release.yaml` it also installs the other components
Adding a note here to avoid any confusion the user may have while following the installation steps.
divyansh42 added a commit to divyansh42/operator that referenced this issue Jun 5, 2024
Fixes: tektoncd#2097
Once the operator is installed through the `release.yaml` it also installs the other components
Adding a note here to avoid any confusion the user may have while following the installation steps.
tekton-robot pushed a commit that referenced this issue Jun 5, 2024
Fixes: #2097
Once the operator is installed through the `release.yaml` it also installs the other components
Adding a note here to avoid any confusion the user may have while following the installation steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants