Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new action for PipelineRun - Edit and Run #2633

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

marniks7
Copy link
Contributor

@marniks7 marniks7 commented Dec 12, 2022

Changes

Add new action for PipelineRun - Edit and Run.
Solves: #2437

  • Action from list of PRs
    image
  • Action from single PR
    image
  • Result of Edit and Run click:
    image
  • YAML page loading while PipelineRun is not fetched yet
    image

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add new feature: ability to edit and run new pipeline (completed or failed or running)

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2022
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2022
@tekton-robot
Copy link
Contributor

Hi @marniks7. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marniks7
Copy link
Contributor Author

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 12, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @marniks7. Overall it looks pretty good. I've left a few suggestions, let me know if you have any questions.

As we discussed on one of the previous issues / PRs I'd like to avoid adding more PipelineRun specific code into the YAML editor so we can more easily reuse it for other resource types in the near future.

packages/e2e/cypress/e2e/run/actions-pipelinerun.cy.js Outdated Show resolved Hide resolved
packages/e2e/cypress/e2e/run/actions-pipelinerun.cy.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.test.js Outdated Show resolved Hide resolved
src/containers/PipelineRun/PipelineRun.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.js Outdated Show resolved Hide resolved
@marniks7
Copy link
Contributor Author

marniks7 commented Dec 17, 2022

Didn't want to create separate PR for an issue with pipelinePendingStatus, in yaml it was status: !<tag:yaml.org,2002:js/undefined>.
It is fixed.

P.s. PR ready for review

@AlanGreene AlanGreene removed the request for review from skaegi January 3, 2023 12:30
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Please also squash your commits when done

src/api/pipelineRuns.test.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.js Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2023
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2023
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marniks7, this is looking pretty good now.

packages/utils/src/utils/index.js Outdated Show resolved Hide resolved
packages/utils/src/utils/index.js Outdated Show resolved Hide resolved
src/api/pipelineRuns.js Outdated Show resolved Hide resolved
src/api/pipelineRuns.js Outdated Show resolved Hide resolved
src/api/pipelineRuns.test.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.js Outdated Show resolved Hide resolved
src/containers/CreatePipelineRun/YAMLEditor.test.js Outdated Show resolved Hide resolved
@marniks7 marniks7 force-pushed the edit-and-run branch 3 times, most recently from d385e75 to 07b1df8 Compare January 19, 2023 03:20
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marniks7. This will be included in the v0.32 release due in the next few days.
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@tekton-robot tekton-robot merged commit 63dce08 into tektoncd:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants