-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit and Run #2437
Comments
Thanks for the feature request @marniks7. I think this makes a lot of sense and would be great to add. However, as you mentioned I also have some concerns about missing support in the existing Create PipelineRun UI, particularly for workspaces, but also array params. Adding a 'Rerun with parameters' (naming might need some work, 'parameters' is an overloaded term) makes it more likely that users will run into issues and could potentially end up with unexpected behaviour depending on how their pipelines are written. I think it's important that the user has full visibility into what they're creating, so not showing unsupported fields but having them passed in the background would not be good. Likewise, stripping unsupported fields wouldn't be great either as it's unlikely this would yield the desired outcome. We're tracking the missing functionality for the Create UI in #1283 and #2171. Any contributions (design, investigation, code, …) on either of those would be very welcome and get us closer to being able to add this new feature safely. |
@AlanGreene , I was thinking about this feature and has another proposal:
|
A YAML input to create a run or edit and rerun an existing one sounds good to me as an escape hatch for unsupported features in the UI or if someone just has a blob of YAML somewhere already that they want to execute.
Can you elaborate on what you mean by this? |
If PipelineRun YAML contains any field except above - we fallback to direct YAML edit, otherwise Another idea: |
I think a good starting point would be to always present the option to switch to 'YAML mode'. That would unblock users who want to use features not currently supported in the UI, and buy us time to figure out the best approach to handle this (new UI, comparison of supported features, detect when UI doesn't support a used feature, etc.). |
Hi @AlanGreene, How do you want to handle this?
Create as YAML
Edit and Run
Important Notes
Model Options and type-safe validations in runtime (for future)
|
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale |
We recently updated the Dashboard to display list and details pages for the new v1beta1 CustomRun (replacement for the deprecated v1alpha1 Run). Now that we have the YAML mode for Create PipelineRun we should add the same (including this edit and rerun feature) for both TaskRun and CustomRun to ensure consistency. |
/area roadmap |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/lifecycle frozen |
Edit and run functionality is available for PipelineRun, TaskRun, and CustomRun resources via the YAML mode editor. There are no current plans to expand the form-based UI capabilities so closing for now. We may revisit this in future as part of broader changes to the app. |
Is your feature request related to a problem ?
CI can be used not only for automated operations, but to run any task that user might need.
E.g. I would like to run E2E tests (pipeline) manually with some parameters. They can fail.
It is nice to be able to change one (few) parameters and rerun it once again.
Or another operation, e.g. download backup, upload backup or run deploy.
Tekton can be used as common purpose pipeline \ workflow engine, e.g. for Chaos Engineering, and to experiment we need to rerun with different parameters like "duration of chaos", "wait"
Describe the solution you'd like
I would like to see 'Rerun with Parameters' near 'Rerun' button for TaskRun\PipelineRun\Run
Jenkins analog: https://plugins.jenkins.io/rebuild/
Describe alternatives you've considered
kubectl apply -f
with different parameters, no alternatives in UIAdditional context
CreatePipelineRun
and add parameterpipelinerun
to url, this parameter can be used astemplate
http://localhost:9097/#/pipelineruns/create?namespace=tekton-namespace&pipelinerun=my-previous-pipeline-run
Rerun with Parameters
for this approach will support only those parameters that are specified inCreatePipelineRun.js
, in particular I am worried about absence of workspaces. This can be done in separate PRThe text was updated successfully, but these errors were encountered: