Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace option to pipeline start #826

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Mar 23, 2020

Add option to set emptydir, pvc, secret and config as workspaces.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2020
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 0.0%

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@khrm khrm changed the title WIP: Add workspace option to pipeline start Add workspace option to pipeline start Mar 26, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@khrm
Copy link
Contributor Author

khrm commented Mar 26, 2020

/test pull-tekton-cli-integration-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

  • I think it should be --workspace instead --workspaces (same way we have resource and param)
  • On validation, I think we need to do more: what happens if I use --workspace name=foo,config=rpg,item=foo,secret=my-secret ? or if I don't use item for config ?

docs/reference/cmd/pipeline_start.md Outdated Show resolved Hide resolved
docs/reference/cmd/pipeline_start.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.2%

@khrm khrm force-pushed the f/workspace branch 2 times, most recently from d17ff7d to 3264e2a Compare March 27, 2020 05:25
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.2%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.2%

Copy link
Member

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@khrm
Copy link
Contributor Author

khrm commented Mar 27, 2020

/test pull-tekton-cli-build-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still do this :

tkn pipeline start cli-release-pipeline --workspace name=waw,secret=secret-name,config=rpg,item=ultimav=1

Which create this workspace…

  workspaces:
  - configMap:
      items:
      - key: ultimav
        path: "1"
      name: rpg
    name: waw

… which should probably error out instead of silently go.

Add option to set emptydir, pvc, secret and config as workspaces.
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/workspaces/workspaces.go Do not exist 97.3%

@khrm
Copy link
Contributor Author

khrm commented Mar 27, 2020

@vdemeester Done.
BTW, items are optional. So I am not checking whether it's given or not.

@@ -0,0 +1,239 @@
// Copyright © 2019 The Tekton Authors.
Copy link
Contributor

@savitaashture savitaashture Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be

Suggested change
// Copyright © 2019 The Tekton Authors.
// Copyright © 2020 The Tekton Authors.

🤔

@@ -0,0 +1,161 @@
// Copyright © 2019 The Tekton Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright © 2019 The Tekton Authors.
// Copyright © 2020 The Tekton Authors.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @savitaashture's suggestion LGTM 👍

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@sthaha
Copy link
Member

sthaha commented Mar 30, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sthaha, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/test pull-tekton-cli-unit-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants