Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace when starting a pipeline or task #651

Closed
siamaksade opened this issue Jan 28, 2020 · 8 comments
Closed

Add workspace when starting a pipeline or task #651

siamaksade opened this issue Jan 28, 2020 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@siamaksade
Copy link

Given the workspace support in pipelines, currently one has to create a PipelineRun yaml in order to start a pipeline that requires a workspace. The tkn pipeline start command should be augmented to be able to map persistent volume claims to workspace when starting a pipeline.

Suggestion:

tkn pipeline start -w|--workspace my-workspace=my-workspace-pvc

The above syntax is similar to pipeline resources

@danielhelfand
Copy link
Member

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 28, 2020
@chmouel
Copy link
Member

chmouel commented Jan 28, 2020

maybe we can have a workspace backed by configmap if no pvc is specified?

@chmouel
Copy link
Member

chmouel commented Jan 28, 2020

/cc @sbwsg

@ghost
Copy link

ghost commented Jan 28, 2020

We also are discussing having an "auto" workspace just in case the user doesn't want / know how to provide one. This would be something the pipeline controller injects in response to some config and would work similarly to how pipeline resources have a PVC generated for them today (called the "artifacts pvc"), but would be more transparent to the user (hopefully).

tektoncd/pipeline#1986

@siamaksade
Copy link
Author

Auto workspace is very useful. Still makes sense to allow users to override it but it would definitely simplify starting pipelines.

@vdemeester vdemeester added this to the 0.9.0 🐺 milestone Mar 9, 2020
@vdemeester vdemeester changed the title Add workspace when starting a pipeline Add workspace when starting a pipeline or atks Mar 9, 2020
@vdemeester vdemeester changed the title Add workspace when starting a pipeline or atks Add workspace when starting a pipeline or task Mar 9, 2020
@vdemeester
Copy link
Member

It could be something like:

  • --workspace my-workspace=pvc/…
  • --workspace my-workspace=emptyDir
  • --workspace my-workspace=configmap/…

@khrm
Copy link
Contributor

khrm commented Mar 11, 2020

/assign khrm

@piyush-garg
Copy link
Contributor

Closed by #826 and #854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants