Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tkn p start --showlog by handling informer ResourceEventHandler #2048

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix tkn p start --showlog by handling informer ResourceEventHandler #2048

merged 1 commit into from
Jun 8, 2023

Commits on Jun 1, 2023

  1. Fix tkn p start --showlog by handling informer ResourceEventHandler 

    tkn p start --showlog command was failing as informer ResourceEventHandler
was calling UpdateFunc after closing channel so it was crashing and showing
error `sending data on closed channel`

so this patch handles informer ResourceEventHandler by synchronization and checks
if channel is closed then return and does nothing

Signed-off-by: ShiV Verma <[email protected]>
    @pratap0007
    pratap0007 committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    0652c63 View commit details
    Browse the repository at this point in the history