Fix tkn p start --showlog by handling informer ResourceEventHandler #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
pratap0007
force-pushed
the
pr-log-resolver
branch
from
9b49b6a
to
754f1be
Compare
vinamra28
reviewed
May 30, 2023
pkg/pipelinerun/tracker.go
Outdated
Comment on lines
109
to
131
| AddFunc: func(obj interface{}) { | ||
| mu.Lock() | ||
| defer mu.Unlock() | ||
| select { | ||
| case <-stopC: | ||
| return | ||
| default: | ||
| eventHandler(obj) | ||
| } | ||
| }, | ||
| UpdateFunc: func(_, newObj interface{}) { | ||
| mu.Lock() | ||
| defer mu.Unlock() | ||
| select { | ||
| case <-stopC: | ||
| return | ||
| default: | ||
| eventHandler(newObj) | ||
| } | ||
| }, | ||
| DeleteFunc: func(obj interface{}) { |
There was a problem hiding this comment.
can you please add comments so that it can be clear to the person who visits this code next time
pratap0007
force-pushed
the
pr-log-resolver
branch
from
754f1be
to
73fdf55
Compare
|
/test pull-tekton-cli-build-tests |
|
@pratap0007 can you update the commit and PR description with the cause and solution for the issue? |
pratap0007
force-pushed
the
pr-log-resolver
branch
from
73fdf55
to
8a5a6aa
Compare
pratap0007
changed the title
tkn p start --showlog command was failing as informer ResourceEventHandler was calling UpdateFunc after closing channel so it was crashing and showing error `sending data on closed channel` so this patch handles informer ResourceEventHandler by synchronization and checks if channel is closed then return and does nothing Signed-off-by: ShiV Verma <[email protected]>
pratap0007
force-pushed
the
pr-log-resolver
branch
from
8a5a6aa
to
0652c63
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tkn p start --showlog by handling informer ResourceEventHandler
tkn p start --showlog command was failing as informer ResourceEventHandler
was calling UpdateFunc after closing channel so it was crashing and showing
error
sending data on closed channelso this patch handles informer ResourceEventHandler by synchronization and checks
if channel is closed then return and does nothing
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes