Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discover fmf with modified-only: true runs all the test if no files were modified #2449

Closed
jchecahi opened this issue Nov 2, 2023 · 0 comments · Fixed by #2761
Closed

discover fmf with modified-only: true runs all the test if no files were modified #2449

jchecahi opened this issue Nov 2, 2023 · 0 comments · Fixed by #2761
Assignees
@lukaszachy
Labels
step | discover Stuff related to the discover step
Milestone
1.32

Comments

@jchecahi
Copy link

jchecahi commented Nov 2, 2023

For a discover config like this:

discover:
  how: fmf
  modified-only: true

If there are no changes, the plan will select all the tests. The issue seems to be here:
https://github.com/teemtee/tmt/blob/main/tmt/steps/discover/fmf.py#L538.

Ideally, if there were no changes in the repo, no tests should be selected.
@lukaszachy lukaszachy added the step | discover Stuff related to the discover step label Nov 8, 2023
@lukaszachy lukaszachy self-assigned this Mar 13, 2024
lukaszachy added a commit that referenced this issue Mar 13, 2024
@lukaszachy
Select no tests if modified-only returns nothing
16147a3 
Previously it selected all tests. Now it respects that if nothing is
modified then nothing is selected.

Fix: #2449
@lukaszachy lukaszachy mentioned this issue Mar 13, 2024
Merged
2 tasks
@lukaszachy lukaszachy added this to the 1.32 milestone Mar 13, 2024
psss pushed a commit that referenced this issue Mar 20, 2024
@lukaszachy @psss
Select no tests if modified-only returns nothing
3b3056f 
Previously it selected all tests. Now it respects that if nothing is
modified then nothing is selected.

Fix: #2449
@psss psss changed the title discover fmf with modified-only: true runs all the test if no files were modified. discover fmf with modified-only: true runs all the test if no files were modified Mar 20, 2024
lukaszachy added a commit that referenced this issue Mar 20, 2024
@lukaszachy
Select no tests if modified-only returns nothing
48c8a85 
Previously it selected all tests. Now it respects that if nothing is
modified then nothing is selected.

Fix: #2449
psss pushed a commit that referenced this issue Mar 20, 2024
@lukaszachy
Select no tests if modified-only returns nothing (#2761)
5131014 
Previously it selected all tests. Now it respects that if nothing is
modified then nothing is selected.

Fix: #2449
The-Mule pushed a commit to The-Mule/tmt that referenced this issue Oct 14, 2024
@lukaszachy @The-Mule
Select no tests if modified-only returns nothing (teemtee#2761)
0a1cf06 
Previously it selected all tests. Now it respects that if nothing is
modified then nothing is selected.

Fix: teemtee#2449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaszachy lukaszachy

Labels
step | discover Stuff related to the discover step
Projects
None yet
Milestone
1.32
Development

Successfully merging a pull request may close this issue.

Select no tests if modified-only returns nothing teemtee/tmt
2 participants
@lukaszachy @jchecahi