Select no tests if modified-only returns nothing
#2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszachy
requested review from
psss,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
Mar 13, 2024
KwisatzHaderach
approved these changes
Mar 19, 2024
psss
force-pushed
the
2449-modified-only-empty
branch
from
fbfd0e0 to
3b3056f
Compare
psss
approved these changes
Mar 20, 2024
psss
changed the title
modified-only returns nothing
happz
approved these changes
Mar 20, 2024
No idea. Any preference? On one side it changes behavior but on the other it changes it to the expected one. |
Yeah, in fact, it just fixes a bug, and probably not that interesting --> I suggest to skip the release note. |
|
Hm, |
|
I'll take a look in the afternoon. That test used to pass before the rebase. |
Previously it selected all tests. Now it respects that if nothing is modified then nothing is selected. Fix: #2449
lukaszachy
force-pushed
the
2449-modified-only-empty
branch
from
3b3056f to
48c8a85
Compare
|
Ah, right. I broke it in fbfd0e0. Fixed now. Tests are good. |
|
Failing tests are known culprits --> merging. |
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
Previously it selected all tests. Now it respects that if nothing is modified then nothing is selected. Fix: teemtee#2449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it selected all tests. Now it respects that if nothing is modified then nothing is selected.
Fix: #2449
Is this worth of release note?
Pull Request Checklist